New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom open() args for stdout_file and stderr_file #83

Merged
merged 1 commit into from Aug 5, 2015

Conversation

Projects
None yet
2 participants
@zoffixznet
Contributor

zoffixznet commented Aug 1, 2015

This allows to specify custom args to open() for stderr_file and stdout_file by supplying an arrayref instead of a string.

I brought in File::Temp to the test prereqs. It's been in the core since 5.6, so that should be fine.

Let me know if any changes are needed.

This was referenced Aug 1, 2015

@symkat

This comment has been minimized.

Show comment
Hide comment
@symkat

symkat Aug 5, 2015

Owner

Can you take a look at the differences between File::Temp 0.14 and 0.18 and see if File::Temp 0.14 will work for your changes? I try to ensure the dependency tree of core D::C can be installed without additional modules on 5.8.1.

corelist File::Temp --version 5.8.1
File::Temp 0.14

(As an aside, I realize there is a dependency on a File::Path version above core/5.8.1, I'll look into that a bit later).

Owner

symkat commented Aug 5, 2015

Can you take a look at the differences between File::Temp 0.14 and 0.18 and see if File::Temp 0.14 will work for your changes? I try to ensure the dependency tree of core D::C can be installed without additional modules on 5.8.1.

corelist File::Temp --version 5.8.1
File::Temp 0.14

(As an aside, I realize there is a dependency on a File::Path version above core/5.8.1, I'll look into that a bit later).

@zoffixznet

This comment has been minimized.

Show comment
Hide comment
@zoffixznet

zoffixznet Aug 5, 2015

Contributor

Hi,

Based on the docs for v0.14 File::Temp, the test should still work fine.

I've updated the version in the Makefile.PL to 0.14

Contributor

zoffixznet commented Aug 5, 2015

Hi,

Based on the docs for v0.14 File::Temp, the test should still work fine.

I've updated the version in the Makefile.PL to 0.14

@symkat

This comment has been minimized.

Show comment
Hide comment
@symkat

symkat Aug 5, 2015

Owner

Great work!

If you'd like, you can add yourself to the contributors block of the POD file as well.

Owner

symkat commented Aug 5, 2015

Great work!

If you'd like, you can add yourself to the contributors block of the POD file as well.

@zoffixznet

This comment has been minimized.

Show comment
Hide comment
@zoffixznet

zoffixznet Aug 5, 2015

Contributor

Thanks. Added.

Contributor

zoffixznet commented Aug 5, 2015

Thanks. Added.

symkat added a commit that referenced this pull request Aug 5, 2015

Merge pull request #83 from zoffixznet/cpan-prc-custom-open
Allow for custom open() args for stdout_file and stderr_file

@symkat symkat merged commit 5f812ae into symkat:master Aug 5, 2015

@zoffixznet zoffixznet deleted the zoffixznet:cpan-prc-custom-open branch Aug 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment