Skip to content
This repository has been archived by the owner. It is now read-only.

Wkb adapter #5

Closed
wants to merge 5 commits into from
Closed

Wkb adapter #5

wants to merge 5 commits into from

Conversation

@ffflabs
Copy link

@ffflabs ffflabs commented Jul 26, 2014

This pull request adds a WKB decoder, and .toWKB() exporting method to all geometries. I tried my best to port this functionality from phayes geoPHP, changing what had to be changed to follow gisconverter logic and exceptions.

I added proper tests and helper methods too.

If it's well received, I'm planning to add:

  • support for big endian (XDR) binaries
  • support for GEOS php extension and methods like simplify, centroid and others
  • Visvalingam simplification much better than regular Douglas Peucker algorithm por webmaps.
ffflabs added 3 commits Jul 25, 2014
changes [] to array() to pass php 5.3 build

fixes scrutinizer objections

move methods
@ffflabs
Copy link
Author

@ffflabs ffflabs commented Jul 30, 2014

@symm bump? 😁

@ffflabs
Copy link
Author

@ffflabs ffflabs commented Aug 7, 2014

Merged 3 commits from master & solved conflicts

@ffflabs
Copy link
Author

@ffflabs ffflabs commented Sep 2, 2014

Dear @symm do you think this could ever see the light?

@symm
Copy link
Owner

@symm symm commented Sep 2, 2014

Hey @amenadiel, thanks for your PR. I haven't been able to check over it yet. It looks like a quite a few changes and I'm sorry I can't find the time at the moment :(

@ffflabs
Copy link
Author

@ffflabs ffflabs commented Sep 3, 2014

@symm that's fine. I hope you get some break soon.

@ffflabs ffflabs closed this Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants