New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wkb adapter #5

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@amenadiel

amenadiel commented Jul 26, 2014

This pull request adds a WKB decoder, and .toWKB() exporting method to all geometries. I tried my best to port this functionality from phayes geoPHP, changing what had to be changed to follow gisconverter logic and exceptions.

I added proper tests and helper methods too.

If it's well received, I'm planning to add:

  • support for big endian (XDR) binaries
  • support for GEOS php extension and methods like simplify, centroid and others
  • Visvalingam simplification much better than regular Douglas Peucker algorithm por webmaps.

amenadiel added some commits Jul 25, 2014

uniform indentation using sublime-codeformatter
changes [] to array() to pass php 5.3 build

fixes scrutinizer objections

move methods
@amenadiel

This comment has been minimized.

Show comment
Hide comment
@amenadiel

amenadiel commented Jul 30, 2014

@symm bump? 😁

@amenadiel

This comment has been minimized.

Show comment
Hide comment
@amenadiel

amenadiel Aug 7, 2014

Merged 3 commits from master & solved conflicts

amenadiel commented Aug 7, 2014

Merged 3 commits from master & solved conflicts

@amenadiel

This comment has been minimized.

Show comment
Hide comment
@amenadiel

amenadiel Sep 2, 2014

Dear @symm do you think this could ever see the light?

amenadiel commented Sep 2, 2014

Dear @symm do you think this could ever see the light?

@symm

This comment has been minimized.

Show comment
Hide comment
@symm

symm Sep 2, 2014

Owner

Hey @amenadiel, thanks for your PR. I haven't been able to check over it yet. It looks like a quite a few changes and I'm sorry I can't find the time at the moment :(

Owner

symm commented Sep 2, 2014

Hey @amenadiel, thanks for your PR. I haven't been able to check over it yet. It looks like a quite a few changes and I'm sorry I can't find the time at the moment :(

@amenadiel

This comment has been minimized.

Show comment
Hide comment
@amenadiel

amenadiel Sep 3, 2014

@symm that's fine. I hope you get some break soon.

amenadiel commented Sep 3, 2014

@symm that's fine. I hope you get some break soon.

@amenadiel amenadiel closed this Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment