Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"false" values in XML file prevent list creation #953

Closed
seblgr opened this issue Jun 5, 2020 · 3 comments · Fixed by #954
Closed

"false" values in XML file prevent list creation #953

seblgr opened this issue Jun 5, 2020 · 3 comments · Fixed by #954
Labels
Milestone

Comments

@seblgr
Copy link
Contributor

seblgr commented Jun 5, 2020

Version

6.2.56

Installation method

source package

Expected behavior

The list should be created

Actual behavior

The list is not created

Additional information

When a XML file used for list creation contains a "false" value (any value that evaluate as false in boolean context), the list is not created.
In the logs, we see the following error :
sympa[15053]: err main::#764 > main::instantiate#1325 > Sympa::Spindle::spin#95 > Sympa::Request::Handler::create_automatic_list::_twist#68 Error in representation data with these xml data

In our family XML file, some lists contains the following line (the tag doesn't matter actually) :
<tag>0</tag>
In Config_XML.pm, line 171

return undef unless $values;

in this case $values contains "0", which is false, thus the parsing ends prematurely and the list is not created.
The others lists in the family are OK.

@ikedas
Copy link
Member

ikedas commented Jun 5, 2020

Hi @seblgr ,
Could you please attach a sample of XML file by which we can reproduce the buggy behavior you reported?

@seblgr
Copy link
Contributor Author

seblgr commented Jun 5, 2020

Hi @ikedas
Here it is :
create_family.zip

I forgot to mention that we don't have that problem in our current production system which is installed with version 6.2.42.

@ikedas ikedas added the bug label Jun 5, 2020
@ikedas ikedas added this to the 6.2.58 milestone Jun 5, 2020
ikedas added a commit to ikedas/sympa that referenced this issue Jun 6, 2020
ikedas added a commit that referenced this issue Jun 6, 2020
"false" values in XML file prevent list creation (#953)
@ikedas
Copy link
Member

ikedas commented Jun 6, 2020

Fixed. Thank you for reporting bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants