Skip to content

✨ — Add "bouncers reset", "bouncers del" and "bouncers [--status] review" commands to sympa.pl - #1098

Merged
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:fix-1058
Mar 5, 2022
Merged

✨ — Add "bouncers reset", "bouncers del" and "bouncers [--status] review" commands to sympa.pl#1098
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:fix-1058

Conversation

@ldidry

@ldidry ldidry commented Jan 26, 2021

Copy link
Copy Markdown
Contributor

Fix #1058

I’m not sure about the --show_status_of_members: I print differently users with bounce attribute, users with suspend attribute and all the others. Is suspend attribute a sign of an error? Should I just print the ok and bounce users?

What are your thoughts about it?

@ldidry
ldidry requested review from ikedas and racke January 26, 2021 14:25
@ikedas

ikedas commented Jan 28, 2021

Copy link
Copy Markdown
Member

This comment has been moved to original issue #1058

  • The word "subscribe"/"unsubscribe" has been used for the actions by the user to add/remove themselves. The word "add"/"del" has been used for the actions by administrators.
  • I feel the options are way too long.

Anyway, how about submit a issue where we may discuss about your PR(s)? I think the discussion may take place on that issue page, and each time when you come to any conclusion, you can submit a PR or push addition to exisiting PR.

@ldidry

ldidry commented Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

The word "subscribe"/"unsubscribe" has been used for the actions by the user to add/remove themselves. The word "add"/"del" has been used for the actions by administrators.

No pb to change that

I feel the options are way too long.

Indeed but I don’t see tha as a problem: sympa.pl has too many options to remember all of them, I think admins check the help to look at the available options. Don’t you think?

Anyway, how about submit a issue where we may discuss about your PR(s)?

Well… why not using issue #1058?

@ikedas

ikedas commented Jan 28, 2021

Copy link
Copy Markdown
Member

Anyway, how about submit a issue where we may discuss about your PR(s)?

Well… why not using issue #1058?

Oh yes, no problem.

Comment thread src/sbin/sympa.pl.in Outdated
@ldidry
ldidry force-pushed the fix-1058 branch 2 times, most recently from 6659b4f to 85d914a Compare February 3, 2022 14:28
Comment thread src/lib/Sympa/Request/Handler/del.pm
@ikedas ikedas changed the title ✨ — Add --cancel-errors-from-list, --unsubscribe-users-in-error-from-list and --show_status_of_members to sympa.pl ✨ — Add "bouncers reset", "bouncers del" and "bouncers [--status] review" commands to sympa.pl Feb 23, 2022
ikedas added a commit that referenced this pull request Mar 5, 2022
…y & ikedas

✨ — Add "bouncers reset", "bouncers del" and "bouncers [--status] review" commands to sympa.pl
@ikedas
ikedas merged commit 1c56975 into sympa-community:sympa-6.2 Mar 5, 2022
@sympa-community sympa-community deleted a comment May 5, 2024
@sympa-community sympa-community deleted a comment May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "bouncers reset", "bouncers del" and "bouncers [--status] review" commands to sympa.pl

2 participants