Fix #533 — Prevent the use of the list address as subscriber - #1343
Merged
Conversation
Member
I documented the procedure to release new source tarball: See "How to prepare a new source tarball". As it includes a step to update |
Contributor
Author
|
Thank you. I updated the wiki |
ikedas
reviewed
Feb 23, 2022
| $log->syslog('err', 'Ignoring %s which is the address of the list', | ||
| $who); | ||
| next; | ||
| } |
Member
There was a problem hiding this comment.
I feel the codes for error handling in add.pm & subscribe.pm are redundant.
We'd be better to insert
push @$stash_ref, ['user', 'email_is_the_list', {email => $who}];before the next line above and withdraw the changes below in add.pm & subscribe.pm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #533, I originally wanted to prevent adding the list address as subscriber with a reception mode which sends mail to the subscriber but:
po/sympa/sympa.potneeds to be updated as I introduce a new localized string. Shoud I runmake -C po/sympa sympa.pot-updateand commitpo/sympa/sympa.potor is there another workflow for that?