Skip to content

Fix #533 — Prevent the use of the list address as subscriber - #1343

Merged
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:fix-533
Mar 28, 2022
Merged

Fix #533 — Prevent the use of the list address as subscriber#1343
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:fix-533

Conversation

@ldidry

@ldidry ldidry commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

In #533, I originally wanted to prevent adding the list address as subscriber with a reception mode which sends mail to the subscriber but:

  • it’s far more easy to just prevint adding the list address as subscriber
  • it would need to prevent changing the reception mode after subscribing, so more work
  • I can’t see a usecase where you want to subscribe with the address of the list. But I think it’s better to have a backend check to prevent it (to avoid typo and other user mistakes)

po/sympa/sympa.pot needs to be updated as I introduce a new localized string. Shoud I run make -C po/sympa sympa.pot-update and commit po/sympa/sympa.pot or is there another workflow for that?

@ldidry
ldidry requested a review from ikedas February 7, 2022 12:50
@ikedas

ikedas commented Feb 9, 2022

Copy link
Copy Markdown
Member

po/sympa/sympa.pot needs to be updated as I introduce a new localized string. Shoud I run make -C po/sympa sympa.pot-update and commit po/sympa/sympa.pot or is there another workflow for that?

I documented the procedure to release new source tarball: See "How to prepare a new source tarball". As it includes a step to update sympa.pot etc., any beta releases may contain the latest catalogs.

@ldidry

ldidry commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

Thank you. I updated the wiki

Comment thread src/lib/Sympa/List.pm
$log->syslog('err', 'Ignoring %s which is the address of the list',
$who);
next;
}

@ikedas ikedas Feb 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the codes for error handling in add.pm & subscribe.pm are redundant.

We'd be better to insert

push @$stash_ref, ['user', 'email_is_the_list', {email => $who}];

before the next line above and withdraw the changes below in add.pm & subscribe.pm.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @ldidry ?

@ikedas
ikedas merged commit 4fa7a8d into sympa-community:sympa-6.2 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants