Skip to content

πŸ› β€” Missing some id on input tags#1358

Merged
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:ldidry-patch-1
Mar 17, 2022
Merged

πŸ› β€” Missing some id on input tags#1358
ikedas merged 1 commit into
sympa-community:sympa-6.2from
ldidry:ldidry-patch-1

Conversation

@ldidry

@ldidry ldidry commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Therefore, clicking on the label did not change the state of the checkbox.

@ldidry ldidry changed the title πŸ› β€” Missing input id in checkbox input πŸ› β€” Missing id in checkbox input Mar 8, 2022
@ikedas

ikedas commented Mar 9, 2022

Copy link
Copy Markdown
Member

There are more elements missing id properties, as far as I know:

  • arcsearch_form.tt2:
    directories
  • d_properties.tt2:
    new_name
  • review.tt2:
    param.[% pS.name %].[% oI %].[kS.name ] (typo in template syntax)
  • scenario_test.tt2:
    remote_addr
    remote_host

@ikedas ikedas added the bug label Mar 9, 2022
@ldidry ldidry changed the title πŸ› β€” Missing id in checkbox input πŸ› β€” Missing some id on input tags Mar 9, 2022
@ldidry

ldidry commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the other missing ids. I added them.

@ikedas ikedas merged commit 7793e7c into sympa-community:sympa-6.2 Mar 17, 2022
@ikedas ikedas added this to the 6.2.70 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants