New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed url parameters and added cookies to preserve tab status #20

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@cremol

cremol commented Sep 18, 2013

No description provided.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 5, 2013

Member

@brendo This extension needs some love. This PR seems really nice to me.

Member

nitriques commented Nov 5, 2013

@brendo This extension needs some love. This PR seems really nice to me.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 7, 2013

Member

On a second though, I think this should me implemented using local storage instead of a cookie.

Member

nitriques commented Nov 7, 2013

On a second though, I think this should me implemented using local storage instead of a cookie.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Nov 7, 2013

Member

Local storage would be a better solution and we already use it in Symphony
:)
On 8 Nov 2013 00:59, "Nicolas Brassard" notifications@github.com wrote:

On a second though, I think this should me implemented using local storage
instead of a cookie.


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-27972125
.

Member

brendo commented Nov 7, 2013

Local storage would be a better solution and we already use it in Symphony
:)
On 8 Nov 2013 00:59, "Nicolas Brassard" notifications@github.com wrote:

On a second though, I think this should me implemented using local storage
instead of a cookie.


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-27972125
.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 7, 2013

Member

I'll see what I can do about that.

Member

nitriques commented Nov 7, 2013

I'll see what I can do about that.

@nitriques nitriques referenced this pull request Nov 12, 2013

Merged

Local storage #26

brendo added a commit that referenced this pull request May 29, 2014

Merge pull request #26 from DeuxHuitHuit/local-storage
Add local storage saving of tabs. Closes #20, #21, #22

@brendo brendo closed this May 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment