New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output of Source-DS-Parameters in Union-DS #35

Closed
animaux opened this Issue Apr 24, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@animaux

animaux commented Apr 24, 2014

In the readme it states that parameters are passed through. This doesn’t seem to be the case.

Symphony 2.3.6
Union Datasource 1.0.4

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann May 12, 2014

Member

I can confirm this issue.
@brendo, any idea why this is failing?

Member

nilshoerrmann commented May 12, 2014

I can confirm this issue.
@brendo, any idea why this is failing?

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 13, 2014

Member

Confirmed (2.5), looking into it.

Member

brendo commented Aug 13, 2014

Confirmed (2.5), looking into it.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 13, 2014

Member

@nilshoerrmann @animaux Do you think you'd be able to test the integration branch on your 2.3.6 install and let me know if things are working for you? I'm just not sure if the changes I've made break pre 2.4 compatibility or not.

Member

brendo commented Aug 13, 2014

@nilshoerrmann @animaux Do you think you'd be able to test the integration branch on your 2.3.6 install and let me know if things are working for you? I'm just not sure if the changes I've made break pre 2.4 compatibility or not.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Aug 13, 2014

Member

I only have a 2.5 version to test on – so that doesn't help, I guess.

Member

nilshoerrmann commented Aug 13, 2014

I only have a 2.5 version to test on – so that doesn't help, I guess.

@animaux

This comment has been minimized.

Show comment
Hide comment
@animaux

animaux Aug 13, 2014

Seems to break in 2.3.6. No options are visible in the DS-editor when choosing union-datasource.

animaux commented Aug 13, 2014

Seems to break in 2.3.6. No options are visible in the DS-editor when choosing union-datasource.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 19, 2014

Member

Ok, I think d21c6f7 broke pre 2.4 compatibility. For your immediate fix, does applying the fix in f5c226d help?

Member

brendo commented Aug 19, 2014

Ok, I think d21c6f7 broke pre 2.4 compatibility. For your immediate fix, does applying the fix in f5c226d help?

@animaux

This comment has been minimized.

Show comment
Hide comment
@animaux

animaux Sep 1, 2014

@brendo I tried to recapitulate this on a local installation but got entangled in other problems so I wasn’t able to try (I had a workaround for that site).

If anyone else needs this it’s good to have your hint immortalised here. :) Cheers!

animaux commented Sep 1, 2014

@brendo I tried to recapitulate this on a local installation but got entangled in other problems so I wasn’t able to try (I had a workaround for that site).

If anyone else needs this it’s good to have your hint immortalised here. :) Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment