New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union DS does not resolve dependencies of included DSs #7

Closed
michael-e opened this Issue Jan 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@michael-e
Member

michael-e commented Jan 6, 2012

As posted in the forum:

At the moment a Union DS can have its own dependencies array which would be resolved if the array was set correctly upon saving. (This is not the case, the array is always empty.)

But it would be much better to remove the dependencies array from the constructor function and actively resolve dependencies for every Datasource which is included in the Union Datasource.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Jan 11, 2012

Member

@michael-e, I've pushed to integration if you'd like to have a test before I release 0.6 :)

Member

brendo commented Jan 11, 2012

@michael-e, I've pushed to integration if you'd like to have a test before I release 0.6 :)

@michael-e

This comment has been minimized.

Show comment
Hide comment
@michael-e

michael-e Jan 11, 2012

Member

Confirmed that dependencies are written to the Union DS file. (According to our previous tests those dependencies should actually work as intended, but I have not verified this.)

Also confirmed that #5 is fixed.

Member

michael-e commented Jan 11, 2012

Confirmed that dependencies are written to the Union DS file. (According to our previous tests those dependencies should actually work as intended, but I have not verified this.)

Also confirmed that #5 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment