Experimental#7
Merged
Merged
Conversation
in preparation for enabling the ability to choose ZIP archive or overwriting existing install files
… only if all files save successfully.
The /manifest/tmp directory must be writable to successfully create a ZIP archive.
Member
Author
|
Another good reason for the ability to overwrite the install files is for those who don't have ZIP support on their server. All they really need is the ability to update these files. They can ZIP, TAR or whatever they like after that. |
Member
|
I've merged these changes @bauhouse. If you could write a couple of bullets for inclusion in the 1.15 changelog, that would be much appreciated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds the ability to overwrite the install files:
install.php,install.sqlandworkspace/install.sql. It's a pretty significant change in behaviour over past versions, but I find it essential for ensemble development when developing with Git. And it's working well with very complex sites with a lot of extensions, including the Members extension. It would be good to release it along with the final release of the Members extension.