Permalink
Commits on Apr 26, 2016
  1. 2.0.0 release notes

    nitriques committed Apr 26, 2016
  2. Fixed the .htaccess update script

    nitriques committed Apr 23, 2016
    The token part was a copy/paste error
Commits on Mar 24, 2016
  1. Better error messages when writing file fails

    nitriques committed Mar 24, 2016
    Since it can be a problem of ACL on the directory, this updates the
    message to tell the user that the problem can also be at the directory
    level.
    
    Closes #107
    
    Fixed based on
    symphonycms/symphony-2@e7febad
  2. Do not override previously registered launcher

    nitriques committed Mar 24, 2016
    If another extension previously registered a custom launcher, the
    current code would bypass it.
    
    This commit makes sure we can still call the previously registered
    launcher before reverting to the default one.
    
    Re #98
  3. 2.0.0 update script

    nitriques committed Mar 24, 2016
    Change the RewriteRule to match the new one, usign Symphony's launcher
Commits on Mar 23, 2016
  1. grab() is now execute()

    nitriques committed Mar 23, 2016
  2. fixed whitespaces

    nitriques committed Mar 23, 2016
  3. PSR-2 formatting

    nitriques committed Mar 23, 2016
    This is the result of running `phpcbf --standard=PSR2 *.php **/*.php`
Commits on Mar 22, 2016
  1. Made __construct and __render protected

    nitriques committed Mar 22, 2016
    This allow extensibility.
    
    Fixes #97
  2. Get all the filters working as they used to

    brendo authored and nitriques committed Jan 1, 2015
    Rebased version of 2d8ed7d
  3. Spaces/strip trailing slashes

    brendo authored and nitriques committed Jan 1, 2015
    Functionality remains unchanged
    
    Rebased version of f361d45
  4. JIT image process is it's own Symphony renderer

    brendo authored and nitriques committed Nov 24, 2014
    Just a commit of everything locally, don't think this works at all yet
    
    Rebased version of 3b04a03
    
    Switch to semver: Fixes #104
  5. Cache width/height function calls during Cropping

    brendo authored and nitriques committed Jan 2, 2015
    Rebased (empty) version of 3629d85
  6. Added a warning for disabling dynamic urls

    nitriques committed Mar 22, 2016
    This would break image previews in the backend.
    
    Fixes #41
Commits on Mar 21, 2016
  1. Add option for CORS headers

    Tommaso Lanza authored and nitriques committed Jul 4, 2015
    Rebased version of c4b4d04
    
    Bump version
    
    Rebased version of eafb979
    
    Listen to OPTIONS requesut
    
    Rebased version of 0168442
  2. 2016 baby!

    nitriques committed Mar 21, 2016
  3. Added configurable max-age value

    nitriques committed Mar 21, 2016
    This hidden configuration will allow developers to tune the max-age
    directive sent with images.
    
    The default has been changed from 1 year to 3 days.
    
    Fixes #88
  4. Improve browser caching: add max-age directive

    bjornpost authored and nitriques committed Aug 11, 2014
    Right now, we're just sending a `public` Cache-Control directive. Google suggests:
    
    > It is important to specify one of Expires or Cache-Control max-age, and one of Last-Modified or ETag, for all cacheable resources. It is redundant to specify both Expires and Cache-Control: max-age, or to specify both Last-Modified and ETag.
     - https://developers.google.com/speed/docs/best-practices/caching?csw=1#LeverageBrowserCaching
    
    This PR implements a Cache-Control max-age directive.
    
    Re #88. Rebased version of 5dfbe96
  5. htaccess should not be written if it doesn't exist

    siimsoni authored and nitriques committed Mar 10, 2016
    .htaccess may not be present in alternate server configurations.
    Updated handling error conditions.
    
    Re #119
    
    Rebased version of 0139b70
Commits on Mar 14, 2016
Commits on Feb 28, 2016
  1. Handle when external responses are not images. Mock the same error re…

    brendo committed Feb 28, 2016
    …porting settings as before to ensure behaviour is backwards compatible (this should change...)
Commits on Feb 5, 2016
  1. preg_replace with the /e modifier is deprecated in PHP 5.5+, switch t…

    brendo committed Feb 5, 2016
    …o using preg_replace_callback
Commits on Jan 12, 2016
  1. Release 1.44

    nitriques committed Jan 12, 2016
Commits on Jan 10, 2016
  1. Support empty .htaccess files

    siimsoni committed Jan 10, 2016
    file_put_contents() returning zero is not a failure condition; it only
    indicates that no bytes were written. Added a strict check to evaluate if
    result was false.
Commits on Aug 25, 2015
  1. Release 1.43

    brendo committed Aug 25, 2015
  2. Merge branch 'integration'

    brendo committed Aug 25, 2015
Commits on Aug 24, 2015
  1. Release 1.42

    brendo committed Aug 24, 2015
  2. Release 1.42

    brendo committed Aug 24, 2015
Commits on Aug 13, 2015
  1. Merge pull request #111 from tmslnz/master

    brendo committed Aug 13, 2015
    Fix JIT error with regex recipes
Commits on Aug 12, 2015
  1. Fix JIT error with regex

    tmslnz committed Aug 12, 2015
    `break 2` is causing regex mode to fail. I am not sure why though as it makes sense to break out the `foreach` if the `$url-parameter` matches.
    
    I’m using capture groups. Symphony errors out in both 2.3.6 (!) and 2.6.2. In both cases removing the break argument `2` resolves the issue. I don’t have the error log for 2.6.2 at hand, but 2.3.6 prints the following:
    
    ```txt
    2015/08/12 23:48:43 > Warning: 2 - preg_match(): Unknown modifier 'r' in file /home/user/webapps/site/symphony/extensions/jit_image_manipulation/lib/image.php on line 63
    2015/08/12 23:48:43 > Notice: Image class param dump - mode: 0, width: 0, height: 0, position: 0, background: 0, file: , external: 0, raw input: resize-width-huge-0/images/image.jpg
    ```
    
    The JIT recipe file is this:
    
    ```php
    <?php
    
    	$recipes = array(
    
    		########
    		array(
    			'mode' => 'regex',
    			'name' => 'Resize Width Small',
    			'url-parameter' => '/resize-width-small-([0-1])/i',
    			'jit-parameter' => '1/800/0/$1',
    			'quality' => '85',
    		),
    		########
    
    		########
    		array(
    			'mode' => 'regex',
    			'name' => 'Resize Width Medium',
    			'url-parameter' => '/resize-width-medium-([0-1])/i',
    			'jit-parameter' => '1/1200/0/$1',
    			'quality' => '85',
    		),
    		########
    
    		########
    		array(
    			'mode' => 'regex',
    			'name' => 'Resize Width Large',
    			'url-parameter' => '/resize-width-large-([0-1])/i',
    			'jit-parameter' => '1/1800/0/$1',
    			'quality' => '80',
    		),
    		########
    
    		########
    		array(
    			'mode' => 'regex',
    			'name' => 'Resize Width Huge',
    			'url-parameter' => '/resize-width-huge-([0-1])/i',
    			'jit-parameter' => '1/2400/0/$1',
    			'quality' => '75',
    		),
    		########
    
    	);
    
    ```