New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GD library CMYK to RGB rendering #47

Closed
andrewminton opened this Issue Nov 5, 2012 · 8 comments

Comments

Projects
None yet
3 participants
@andrewminton

andrewminton commented Nov 5, 2012

As of GD version 2.0.22 there is simple support for CMYK to RGB conversion on the fly so that older browsers may be able to handle images uploaded with CMYK colourspace.

Is there scope to cater for this in the 3 channel meta check conditional within the extension maybe?

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Nov 7, 2012

Member

I think it'd be a good idea to investigate so we can eliminate this problem where possible.

Member

brendo commented Nov 7, 2012

I think it'd be a good idea to investigate so we can eliminate this problem where possible.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Jan 13, 2013

Member

+1 for this, a lot of my client upload CMYK images without being aware that CMYK and RGB exists.

Member

nitriques commented Jan 13, 2013

+1 for this, a lot of my client upload CMYK images without being aware that CMYK and RGB exists.

@andrewminton

This comment has been minimized.

Show comment
Hide comment
@andrewminton

andrewminton Dec 24, 2014

Any further thoughts on this? the check for 3 channels still exists in the current and integration branches and seeing as there have been moves to update JIT recently was wondering if people had further thoughts on this.

What if we did a check for installed GD version and use current implementation as a fallback but open up the ability to process CMYK images as of GD 2.0.22? just a thought.

andrewminton commented Dec 24, 2014

Any further thoughts on this? the check for 3 channels still exists in the current and integration branches and seeing as there have been moves to update JIT recently was wondering if people had further thoughts on this.

What if we did a check for installed GD version and use current implementation as a fallback but open up the ability to process CMYK images as of GD 2.0.22? just a thought.

@andrewminton

This comment has been minimized.

Show comment
Hide comment
@andrewminton

andrewminton Dec 24, 2014

P.S. Merry Christmas :)

andrewminton commented Dec 24, 2014

P.S. Merry Christmas :)

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Jan 1, 2015

Member

How would you implement it ? Not the version checking, but the RGB conversion ? Happy new year BTW!

Member

nitriques commented Jan 1, 2015

How would you implement it ? Not the version checking, but the RGB conversion ? Happy new year BTW!

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Jan 2, 2015

Member

It happens automatically by GD. I've committed this change on integration.

Member

brendo commented Jan 2, 2015

It happens automatically by GD. I've committed this change on integration.

@andrewminton

This comment has been minimized.

Show comment
Hide comment
@andrewminton

andrewminton commented Jan 2, 2015

Nice one @brendo :)

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques
Member

nitriques commented Jan 7, 2015

+1 @brendo

@brendo brendo closed this Jan 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment