Reject invalid sizes #100
Merged
Reject invalid sizes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I came across lots of logs regarding jit image trying to use 0 x 0 has their dimensions. Each time it happend, 13 log entries where recreated!!! This fix now exit early in that case, to prevent poluting the log.
Yeah, it'd be nice to log this so you're still aware that it's occurring. With referrer would be ideal. |
|
Perfect. |
The invalid size error now logs a message in Symphony's log. The referrer is added in the log message, if present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across lots of logs regarding jit image trying to use 0 x 0 has their dimensions. Each time it happend, 13 log entries where recreated!!! This fix now exit early in that case, to prevent poluting the log.
Should we still log it ? (but only once!)