New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid sizes #100

Merged
merged 2 commits into from Feb 8, 2015

Conversation

Projects
None yet
2 participants
@nitriques
Member

nitriques commented Jan 12, 2015

I came across lots of logs regarding jit image trying to use 0 x 0 has their dimensions. Each time it happend, 13 log entries where recreated!!! This fix now exit early in that case, to prevent poluting the log.

Should we still log it ? (but only once!)

Reject invalid sizes
I came across lots of logs regarding jit image trying to use 0 x 0 has their dimensions. Each time it happend, 13 log entries where recreated!!! This fix now exit early in that case, to prevent poluting the log.
@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Jan 12, 2015

Member

Should we still log it ? (but only once!)

Yeah, it'd be nice to log this so you're still aware that it's occurring. With referrer would be ideal.

Member

brendo commented Jan 12, 2015

Should we still log it ? (but only once!)

Yeah, it'd be nice to log this so you're still aware that it's occurring. With referrer would be ideal.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Jan 12, 2015

Member

Perfect.

Member

nitriques commented Jan 12, 2015

Perfect.

@nitriques nitriques self-assigned this Jan 13, 2015

Add a log entry when the size is invalid
The invalid size error now logs a message in Symphony's log.
The referrer is added in the log message, if present.
@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Jan 13, 2015

Member

There you go @brendo, I've added the log message.

Also, I wonder what's best for initializing the log: as I did ? Or like this ?

Member

nitriques commented Jan 13, 2015

There you go @brendo, I've added the log message.

Also, I wonder what's best for initializing the log: as I did ? Or like this ?

brendo added a commit that referenced this pull request Feb 8, 2015

Merge pull request #100 from DeuxHuitHuit/zero
Reject invalid size requests.

@brendo brendo merged commit a95674e into symphonycms:integration Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment