New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public role permissions will only work after saving #242

Closed
azzagazz opened this Issue Apr 17, 2014 · 7 comments

Comments

Projects
None yet
4 participants
@azzagazz

azzagazz commented Apr 17, 2014

it seems that the default public role displays all event level permissions as No edit (like every other newly created role) but does not actually set these permissions until after the first time it is saved. so by default it has no access restrictions set.

@azzagazz azzagazz changed the title from Public roles permissions will only work after saving to Public role permissions will only work after saving Apr 17, 2014

@michael-e

This comment has been minimized.

Show comment
Hide comment
@michael-e

michael-e Apr 17, 2014

Member

What is really anoying here: If you forget to save the permssions for a new event, everything will work. But then, when you save the role permissions (some days or weeks later), suddenly some of your events won't work anymore.

Member

michael-e commented Apr 17, 2014

What is really anoying here: If you forget to save the permssions for a new event, everything will work. But then, when you save the role permissions (some days or weeks later), suddenly some of your events won't work anymore.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 9, 2014

Member

Hey, I'm having a bit of trouble following this. First time what is saved? The Event? The Role? The Member entry?

Member

brendo commented Aug 9, 2014

Hey, I'm having a bit of trouble following this. First time what is saved? The Event? The Role? The Member entry?

@michael-e

This comment has been minimized.

Show comment
Hide comment
@michael-e

michael-e Aug 9, 2014

Member

Sorry. It's the role.

Any events which have been created since the last saving of a role will be allowed by default, because nothing has been saved at all for these new events. If you then save the role, you won't even remember which events have been attached since the last save — but all of these will suddenly "break", because the default permissions are strict (which is good).

The solution would be: Until any permissions for an event are saved, the permissions layer defaults to "nothing allowed".

Member

michael-e commented Aug 9, 2014

Sorry. It's the role.

Any events which have been created since the last saving of a role will be allowed by default, because nothing has been saved at all for these new events. If you then save the role, you won't even remember which events have been attached since the last save — but all of these will suddenly "break", because the default permissions are strict (which is good).

The solution would be: Until any permissions for an event are saved, the permissions layer defaults to "nothing allowed".

@designermonkey

This comment has been minimized.

Show comment
Hide comment
@designermonkey

designermonkey Aug 9, 2014

Member

I came across this yesterday, and just thought it was me.

Applying the permissions of 'nothing allowed' is not the right answer for me. Whatever the default event permissions for a Public role should be applied.

Member

designermonkey commented Aug 9, 2014

I came across this yesterday, and just thought it was me.

Applying the permissions of 'nothing allowed' is not the right answer for me. Whatever the default event permissions for a Public role should be applied.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 9, 2014

Member

Ah great, that makes sense. I concur, shall update.

Member

brendo commented Aug 9, 2014

Ah great, that makes sense. I concur, shall update.

brendo added a commit that referenced this issue Aug 9, 2014

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Aug 9, 2014

Member

Well that was a simple fix ;)

Member

brendo commented Aug 9, 2014

Well that was a simple fix ;)

@brendo brendo closed this Aug 9, 2014

@michael-e

This comment has been minimized.

Show comment
Hide comment
@michael-e

michael-e Aug 9, 2014

Member

@designermonkey:

Whatever the default event permissions for a Public role should be applied.

No, I think that even this role should be saved in order to apply the permissions. It's not logical to auto-apply these permissions.

@brendo: Thanks a lot, this will save me a lot of time in the future. I tripped on this so often…

Member

michael-e commented Aug 9, 2014

@designermonkey:

Whatever the default event permissions for a Public role should be applied.

No, I think that even this role should be saved in order to apply the permissions. It's not logical to auto-apply these permissions.

@brendo: Thanks a lot, this will save me a lot of time in the future. I tripped on this so often…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment