New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Author Field by Value or Handle #2244

Closed
nilshoerrmann opened this Issue Nov 5, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@nilshoerrmann
Member

nilshoerrmann commented Nov 5, 2014

The author field does not allow filtering by value or handle. As discussed in #2073, adding this feature would remove the need to convert between string values and ids for the backend filtering.

@brendo brendo added this to the 2.6.0 milestone Nov 5, 2014

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Nov 5, 2014

Member

Just as an FYI, if the Author field is not passed an ID, I will have to make a decision as to what field I will filter on. At this stage, I'm leaning towards filtering on username.

  • Numeric value => filter on Author ID
  • Text value => filter on Username

Any objections?

Member

brendo commented Nov 5, 2014

Just as an FYI, if the Author field is not passed an ID, I will have to make a decision as to what field I will filter on. At this stage, I'm leaning towards filtering on username.

  • Numeric value => filter on Author ID
  • Text value => filter on Username

Any objections?

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 6, 2014

Member

No, that sounds quite logical.

Member

nilshoerrmann commented Nov 6, 2014

No, that sounds quite logical.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 6, 2014

Member

No, that sounds quite logical.

I agree.

Member

nitriques commented Nov 6, 2014

No, that sounds quite logical.

I agree.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 11, 2014

Member

I just can across the fact, that Symphony uses the full name (first name + last name) in other places.
This is what the field returns as toggle values.

Member

nilshoerrmann commented Nov 11, 2014

I just can across the fact, that Symphony uses the full name (first name + last name) in other places.
This is what the field returns as toggle values.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Nov 12, 2014

Member

I guess I could do both?

Member

brendo commented Nov 12, 2014

I guess I could do both?

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 13, 2014

Member

Yes, please do!

Member

nitriques commented Nov 13, 2014

Yes, please do!

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Nov 13, 2014

Member

Heh, amazing what you find when you have a look. The Author field already supports Author ID's or Usernames, https://github.com/symphonycms/symphony-2/blob/integration/symphony/lib/toolkit/fields/field.author.php#L464-L485 and has done since Symphony 2.2

Member

brendo commented Nov 13, 2014

Heh, amazing what you find when you have a look. The Author field already supports Author ID's or Usernames, https://github.com/symphonycms/symphony-2/blob/integration/symphony/lib/toolkit/fields/field.author.php#L464-L485 and has done since Symphony 2.2

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 13, 2014

Member

The problem is that the field returns the full names as toggle states …

Member

nilshoerrmann commented Nov 13, 2014

The problem is that the field returns the full names as toggle states …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment