New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Filtering: Issues with contains and not contains #2288

Closed
jensscherbl opened this Issue Dec 4, 2014 · 15 comments

Comments

Projects
None yet
3 participants
@jensscherbl
Member

jensscherbl commented Dec 4, 2014

Comparison info is missing for contains and does not cointain, empty suggestion panel looks buggy.

screen shot 2014-12-04 at 12 55 42

screen shot 2014-12-04 at 12 55 48

Comparison select box jumps back to is after applying a filter, even though contains or does not contain was selected. First character is missing from filter value (only for contains and does not contain).

screen shot 2014-12-04 at 12 57 04

screen shot 2014-12-04 at 12 57 08

Markup is created twice for fields with pre-existing filters (JavaScript disabled for debugging).

screen shot 2014-12-04 at 13 16 36

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 4, 2014

Member

Just to double check, what version are you running at the moment?

Member

brendo commented Dec 4, 2014

Just to double check, what version are you running at the moment?

@jensscherbl

This comment has been minimized.

Show comment
Hide comment
@jensscherbl

jensscherbl Dec 5, 2014

Member

Issues above occured on integration.

Member

jensscherbl commented Dec 5, 2014

Issues above occured on integration.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 5, 2014

Member

Regarding the issues:

  • the empty list shouldn't be visible, this is a CSS issue (@nilshoerrmann)
  • this must be a PHP issue, because this is where the interface is rebuilt on page load (@brendo)
  • I'll have to check the markup, but is it possible that the interface – without JS enabled – displays the .template elements? (@nilshoerrmann)
Member

nilshoerrmann commented Dec 5, 2014

Regarding the issues:

  • the empty list shouldn't be visible, this is a CSS issue (@nilshoerrmann)
  • this must be a PHP issue, because this is where the interface is rebuilt on page load (@brendo)
  • I'll have to check the markup, but is it possible that the interface – without JS enabled – displays the .template elements? (@nilshoerrmann)
@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 12, 2014

Member

I'll take a look at this tomorrow 👍 Would love a solid Christmas beta :)

Member

brendo commented Dec 12, 2014

I'll take a look at this tomorrow 👍 Would love a solid Christmas beta :)

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 12, 2014

Member

I can have a look at this over the weekend as well.

Member

nilshoerrmann commented Dec 12, 2014

I can have a look at this over the weekend as well.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 14, 2014

Member

The filter help should now display correctly again and templates should be invisible.

Member

nilshoerrmann commented Dec 14, 2014

The filter help should now display correctly again and templates should be invisible.

nilshoerrmann added a commit that referenced this issue Dec 14, 2014

@jensscherbl

This comment has been minimized.

Show comment
Hide comment
@jensscherbl

jensscherbl Dec 14, 2014

Member

The filter help should now display correctly again and templates should be invisible.

Yep.

Comparison select box jumps back to is after applying a filter, even though contains or does not contain was selected. First character is missing from filter value (only for contains and does not contain).

This is still an issue.

Also, the suggestions seem to be always one keypress behind.

Don't get me wrong, but did you ever try to actually use this (the filtering UI) yourself? Most of the issues I encounter seem pretty obvious to me, and I find it hard to believe you never noticed these things.

Member

jensscherbl commented Dec 14, 2014

The filter help should now display correctly again and templates should be invisible.

Yep.

Comparison select box jumps back to is after applying a filter, even though contains or does not contain was selected. First character is missing from filter value (only for contains and does not contain).

This is still an issue.

Also, the suggestions seem to be always one keypress behind.

Don't get me wrong, but did you ever try to actually use this (the filtering UI) yourself? Most of the issues I encounter seem pretty obvious to me, and I find it hard to believe you never noticed these things.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 14, 2014

Member

No, I usually just hit the keyboard randomly ;)
I didn't say the full issue has been resolved, just the two mentioned aspects. We still have a few regressions caused by DSE changes (backwards compatibility).

Member

nilshoerrmann commented Dec 14, 2014

No, I usually just hit the keyboard randomly ;)
I didn't say the full issue has been resolved, just the two mentioned aspects. We still have a few regressions caused by DSE changes (backwards compatibility).

@jensscherbl

This comment has been minimized.

Show comment
Hide comment
@jensscherbl

jensscherbl Dec 14, 2014

Member

I didn't say the full issue has been resolved

Not picking on the current progress, just still a bit worried about the fact that the filtering UI has been merged and released in the first place when it obviously had so many problems...

Member

jensscherbl commented Dec 14, 2014

I didn't say the full issue has been resolved

Not picking on the current progress, just still a bit worried about the fact that the filtering UI has been merged and released in the first place when it obviously had so many problems...

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 15, 2014

Member

I consider this a mistake today. But the filtering worked really good for the default fields (we've been using it a lot) – extensions like SBL were causing most of the trouble.

Regarding the current update: there were some changes how we trim strings after the merge that seem to cause the remaining issues.

Member

nilshoerrmann commented Dec 15, 2014

I consider this a mistake today. But the filtering worked really good for the default fields (we've been using it a lot) – extensions like SBL were causing most of the trouble.

Regarding the current update: there were some changes how we trim strings after the merge that seem to cause the remaining issues.

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 15, 2014

Member

Comparison select box jumps back to is after applying a filter, even though contains or does not contain was selected. First character is missing from filter value (only for contains and does not contain).
This is still an issue.

Is this something I can solve? Got any tips where to start? I'm feeling like this is being overwritten by the duplicator logic?

Member

brendo commented Dec 15, 2014

Comparison select box jumps back to is after applying a filter, even though contains or does not contain was selected. First character is missing from filter value (only for contains and does not contain).
This is still an issue.

Is this something I can solve? Got any tips where to start? I'm feeling like this is being overwritten by the duplicator logic?

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 15, 2014

Member

Not picking on the current progress, just still a bit worried about the fact that the filtering UI has been merged and released in the first place when it obviously had so many problems...

Hindsight is 20/20. The release went through it's usual development, beta and release candidate cycles and these issues were not discovered. Most are not critical (annoying sure, but not damaging) and have since been resolved (either with 2.5.x releases or currently on integration). It's nice to dwell, but in the end that's not the right way to push forward. Bug reports are the right outlet and as we've seen, the issues are being resolved now.

Member

brendo commented Dec 15, 2014

Not picking on the current progress, just still a bit worried about the fact that the filtering UI has been merged and released in the first place when it obviously had so many problems...

Hindsight is 20/20. The release went through it's usual development, beta and release candidate cycles and these issues were not discovered. Most are not critical (annoying sure, but not damaging) and have since been resolved (either with 2.5.x releases or currently on integration). It's nice to dwell, but in the end that's not the right way to push forward. Bug reports are the right outlet and as we've seen, the issues are being resolved now.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Dec 15, 2014

Member

This shouldn't be a Duplicator issue because it just takes the markup provided. And my guess is that this markup is not generated correctly. There were some changes after merging the filtering branch that introduced trimming (I think this was needed when you made the is filter configurable – I don't remember why anymore). So maybe the current filter is no longer selected because the comparison doesn't match anymore (regexp: compared to regexp:).

Member

nilshoerrmann commented Dec 15, 2014

This shouldn't be a Duplicator issue because it just takes the markup provided. And my guess is that this markup is not generated correctly. There were some changes after merging the filtering branch that introduced trimming (I think this was needed when you made the is filter configurable – I don't remember why anymore). So maybe the current filter is no longer selected because the comparison doesn't match anymore (regexp: compared to regexp:).

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 15, 2014

Member

Bingo :)

Member

brendo commented Dec 15, 2014

Bingo :)

brendo added a commit that referenced this issue Dec 15, 2014

@brendo

This comment has been minimized.

Show comment
Hide comment
@brendo

brendo Dec 15, 2014

Member

With the last comment, this issue is resolved.

Member

brendo commented Dec 15, 2014

With the last comment, this issue is resolved.

@brendo brendo closed this Dec 15, 2014

@brendo brendo added this to the 2.6.0 milestone Dec 15, 2014

nitriques added a commit to DeuxHuitHuit/symphonycms that referenced this issue Feb 19, 2015

nitriques added a commit to DeuxHuitHuit/symphonycms that referenced this issue Feb 19, 2015

nitriques added a commit to DeuxHuitHuit/symphonycms that referenced this issue Feb 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment