Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Field Regex filtering broken #710

Closed
designermonkey opened this issue Jul 8, 2011 · 3 comments
Closed

Core Field Regex filtering broken #710

designermonkey opened this issue Jul 8, 2011 · 3 comments
Assignees
Milestone

Comments

@designermonkey
Copy link
Member

When filtering by regexp: if a value isn't passed in the parameter, the filter fails with a MySQL error, instead of a standard error. It needs to check and negate the mysql statement if no value or value = ''.

Please see: http://symphony-cms.com/discuss/thread/73250/#position-4 for issue

And see Nick's response in the same thread for why it happens.

@ghost ghost assigned brendo Jul 9, 2011
@brendo
Copy link
Member

brendo commented Jul 9, 2011

Can you check the above commit @designermonkey. Should resolve this issue (for Core fields anyway)

@designermonkey
Copy link
Member Author

Sorry @brendo, I thought spaces were taken care of before, I didn't spot that, been a little sleepy and unfocused for the last few days.

I will check it a little later, I'm popping in to the office. Cheers for jumping on this dude.

@designermonkey
Copy link
Member Author

Works fine, thanks @brendo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants