Release 2.2.5 #865

Closed
brendo opened this Issue Oct 26, 2011 · 36 comments

Comments

Projects
None yet
8 participants
Owner

brendo commented Oct 26, 2011

My mistake means we'll need another release to fix a Date field issue and major SBL issue.

Hopefully my mistakes are isolated to these two issues ;)

@michael-e is a running a 2.2.4 through it's paces, and I'm using one for a new site build, but if anyone else has a spare 30 minutes or hour, I'd really appreciate if you could checkout the 2.2.x branch and give it a whirl.

Keep in mind that this release has to be solid as it'll be the last of the 2.2.x before 2.3 so it could be in use for some time (think of all your 2.1.x sites you haven't upgraded ;))

Member

michael-e commented Oct 26, 2011

It would be cool to get rid of most of the "strict warnings" PHP throws if you add:

ini_set('display_errors', 'On');
error_reporting(E_ALL | E_STRICT);

and walk through the Symphony backend.

For example, class.administration.php has two occurences of

$this->ExtensionManager

but the ExtensionManager is static now. So PHP will throw:

Strict Standards: Accessing static property Administration::$ExtensionManager as non static in /var/www/maschine/symphony/lib/core/class.administration.php on line 395

Another example:

Notice: Undefined variable: returnSingle in /var/www/maschine/symphony/lib/toolkit/class.fieldmanager.php on line 244

(Probably an easy fix.)

@brendo: If you find the time, cleaning up those notices/warnings would be great.

@ghost ghost assigned brendo Oct 26, 2011

Owner

brendo commented Oct 26, 2011

It'd be nice, but it's not realistic to clean them all up in a single release. It needs to be an ongoing thing and will improve over time :)

I've done a quick cleanup on the ones you explicitly mentioned, but there are many more that we'll hunt down as development progresses.

Member

michael-e commented Oct 26, 2011

Yeah, I never thought we can fix them all in a single try. :-) But having less warnings from the core is definitely useful, especially for extension developers trying to improve the quality of their code. Thanks!

Owner

brendo commented Oct 26, 2011

I've updated the Symphony Tests extension to include more tests to ensure that Date field bug doesn't pop up again (and added a couple of new tests specifically for Date field functionality)

Owner

brendo commented Oct 27, 2011

Did you spot anything else @michael-e? I found a couple of copy related things on the update.php, but nothing critical to Symphony functionality. I'd like to push out a 2.2.5 this weekend (at the very least an RC)

Member

michael-e commented Oct 27, 2011

@brendo: If you update the head for the SBL submodule, I can test with the the 2.2.x repo HEAD. That would be great.

No, I have not found more issues up to now. But I will work with the 2.2.x branch today and tomorrow. We'll see! :-)

Owner

brendo commented Oct 27, 2011

Have done so :)

No, I have not found more issues up to now. But I will work with the 2.2.x branch today and tomorrow. We'll see! :-)

That's a positive start then :) Thanks again for helping out!

Member

michael-e commented Oct 27, 2011

No prob. I myself need this Symphony release to be as stable as possible, 'cause my "big project" must come to an "interim end" soon! :-)

brendo added a commit that referenced this issue Oct 29, 2011

Owner

brendo commented Nov 3, 2011

Here's a zip of a 2.2.5RC1 build. I'd really really really love it if everyone could give it a whirl for 5-10 minutes to test it's stability. I'd really like to get this final and pushed ASAP (the Date bug in 2.2.4 is pretty embarrassing :()

/cc @allen, @czheng, @nickdunn, @nils-werner, @creativedutchmen, @remie, @nilshoerrmann, @designermonkey

Thanks :)

Owner

nilshoerrmann commented Nov 3, 2011

I'll be updating a project I'm currently working on later this morning and will report back if everything is fine.

Owner

brendo commented Nov 3, 2011

Thank you :)

I've deployed another (internal) site today with this branch and I haven't come across any issues either.

Contributor

nils-werner commented Nov 3, 2011

I updated a stub 2.2.4 installation using Git and upon running update.php, it complained about SBL being too old (I was at 1.21, it wanted 1.22).

But after running git submodule update --init my extensions table still said 1.21.

Owner

brendo commented Nov 3, 2011

Yep, I haven't updated the SBL to 1.22 yet as I'm on the master branch (naughty).

Owner

nilshoerrmann commented Nov 3, 2011

I've been updating via Git and everything seems to be just fine here so far. I checked a few date related areas on the front-end and backend and they display correctly here (timezone Berlin, GMT+1). Updater correctly set the new version number as well.

I cannot say anything about the bundled extensions because I'm using a separate submodule with my own set of extensions.

Owner

designermonkey commented Nov 3, 2011

(the Date bug in 2.2.4 is pretty embarrassing :()

Don't be embarrassed, you should see some of the shit I produce sometimes!

Member

michael-e commented Nov 3, 2011

Sorry that I have not replied for days. I am really sick, since days. So I simply can not work on anything "serious".

Contributor

nils-werner commented Nov 3, 2011

Yep, I haven't updated the SBL to 1.22 yet as I'm on the master branch (naughty).

Sorry to be so pedantic but isn't the RC supposed to be an exact image of how it will end up? Meaning: we should do every single bit in the RC, not just in the final, shouldn't we?

Owner

brendo commented Nov 3, 2011

Sorry to be so pedantic but isn't the RC supposed to be an exact image of how it will end up? Meaning: we should do every single bit in the RC, not just in the final, shouldn't we?

Absolutely. The only commit remaining on the SBL is the one to update the version number from 1.21 to 1.22 in both the README and extension driver, so considering that sort of change is identical to what will happen dropping the RC1 for the Symphony repo, I figure it ok (but definitely not great).

Sorry that I have not replied for days. I am really sick, since days. So I simply can not work on anything "serious".

Ouch, all you Europeans have been dropping like flies lately! Get better soon :)

Member

michael-e commented Nov 3, 2011

I did a fresh install and see several issues with extensions not being tracked correctly by the installer:

Cross-Site Scripting (XSS) Filter  1.1    Yes
Debug DevKit                       1.2    Enable to update to 1.2.1
Export Ensemble                    1.16   Yes
Field: Select Box Link             1.20   Enable to update to 1.21
JIT Image Manipulation             1.11   Enable to update to 1.13
Maintenance Mode                   1.4    Enable to update to 1.5
Profile Devkit                     1.0.4  Yes
Text Formatter: Markdown           1.13   Yes

Regarding @nils-werner's point, I second that. Ideally the last RC should be identical to the stable relase (apart from the tag).

Member

michael-e commented Nov 3, 2011

@brendo: Yep, I think I see the submodule issue. But couldn't we work around it by tagging a new SBL version before releasing a Symphony RC?

Member

michael-e commented Nov 3, 2011

The Debug Devkit still has indenting issues. Debugging the default article's page, I see for example:

   <entry>a-primer-to-symphony-2s-default-theme</entry>
    <cat />
    <cookie-username>michael-e</cookie-username>
    <cookie-pass>c99128af4578f794de53fff86813f22d927e6341</cookie-pass>
   <site-mode>live</site-mode>
   <ds-article>
     <item handle="3">3</item>
   </ds-article>

Indenting seems to be a bit random. :-)

Contributor

nickdunn commented Nov 3, 2011

The Debug Devkit still has indenting issues

Yep, known issue.

Contributor

cz commented Nov 3, 2011

You should be able to update and tag a new SBL version on a non-master
branch and then have the RC point to that commit, no?
On Nov 3, 2011 8:27 AM, "michael-e" <
reply@reply.github.com>
wrote:

@brendo: Yep, I think I see the submodule issue. But couldn't we work
around it by tagging a new SBL version before releasing a Symphony RC?

Reply to this email directly or view it on GitHub:
#865 (comment)

Owner

brendo commented Nov 4, 2011

Ok, on lunch today I'll:

  • Tag SBL to 1.22
  • Update the workspace with the correct version numbers for the extensions
  • Have a quick look at the Devkit indenting, it's a cosmetic issue and won't hold up a release though
Owner

brendo commented Nov 4, 2011

Ok SBL tag done, workspace done, devkit...

Contributor

nils-werner commented Nov 4, 2011

By the way shouldn't this be version 2.2.4.1? :-)

Owner

nilshoerrmann commented Nov 4, 2011

Don't be so German :D

Owner

brendo commented Nov 6, 2011

Barring any objections, I'd like to push the 2.2.x branch to master on Wednesday and release 2.2.5.

brendo added a commit that referenced this issue Nov 9, 2011

Owner

brendo commented Nov 9, 2011

Here's an RC2 zip. This includes the tagging updates and the fix for #881. I'll be releasing this at 11:30pm GMT+10.

brendo added a commit that referenced this issue Nov 11, 2011

brendo added a commit that referenced this issue Nov 13, 2011

Member

michael-e commented Nov 13, 2011

It has not been tagged nor released officially, right?

Just asking because I stumbled upon an annoyance with "select type" fields (Select field, SBL field, Pages field)...

I might file an issue anyway, no matter if it's in time for 2.2.5 or not.

Owner

brendo commented Nov 13, 2011

It has not been tagged nor released officially, right?

Not yet, running it through it's paces today, then I'll pull the trigger (about time I hear you say :D)

As noted in #896, it won't stop this release.

I pulled yesterday and noticed Symphony was labelled 2.2.5. So, I upgraded my install (and the SBL): was I too soon?

Owner

brendo commented Nov 15, 2011

Nope, it's fine. The official announcement is just lagging behind while I whip up something special :)

Phew. Im such an early-adopting hipster: "I was using 2.2.5 since before it was cool!" :D

Owner

brendo commented Nov 15, 2011

Closed with http://bit.ly/svJRw1

@brendo brendo closed this Nov 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment