Remove unnecessary ParametersAcceptorSelector::selectSingle handling
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@staabm is it ready for review ? |
Contributor
Author
|
@samsonasik I forgot about this PR. Could you re-start CI? |
Member
|
sure 👍 , just close-reopen to restart it. |
Member
|
Rector seems needs bump to phpstan-extensions/composer.json Line 14 in 5eb198b |
Member
|
class leak ci seems needs skip type https://github.com/symplify/phpstan-extensions/actions/runs/11774947832/job/32794746715?pr=9 |
Contributor
Author
|
done |
samsonasik
approved these changes
Nov 11, 2024
Member
|
Let's give it a try, thank you @staabm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unnecessary use of
ParametersAcceptorSelector::selectSinglewhich is deprecated with PHPStan 2.xanalog symplify/phpstan-rules#142