[CodingStandard] Add ClassNameSuffixByParentFixer

[TomasVotruba]

Closes #607

[carusogabriel]

Nice to have this one 👏

[enumag]

this looks like debug code

[TomasVotruba]

Yep, sorry

[enumag]

Personally I recommend using NEWDOC syntax for multiline strings.

[enumag]

I don't think this does what it's supposed to. Quoting from ConfigurableFixerInterface::configure():

     * New configuration must override current one, not patch it.
     * Using `null` makes fixer to use default configuration (or reset configuration from previously configured back
     * to default one).

[TomasVotruba]

How the code should look like then?

[enumag]

From what I see in default fixtures it should call $this->configuration = $this->getConfigurationDefinition()->resolve([]);. However it is not too important because

            @trigger_error(
                'Passing NULL to set default configuration is deprecated and will not be supported in 3.0, use an empty array instead.',
                E_USER_DEPRECATED
            );

[TomasVotruba]

Alright, I already call that in ctor to prevent missed configuration call.

So here it doesn't have sense anymore

[TomasVotruba]

Alright, I already call that in ctor to prevent missed configuration call.

So here it doesn't have sense anymore

[TomasVotruba]

I've added support for interface types as well.

Any ideas to improve default type map?

    /**
     * @var string[]
     */
    private $defaultParentClassToSuffixMap = [
        '*Command' => 'Command',
        '*Controller' => 'Controller',
        '*Repository' => 'Repository',
        '*Presenter' => 'Presenter',
        '*Request' => 'Request',
        '*EventSubscriber' => 'EventSubscriber',
        '*FixerInterface' => 'Fixer',
        '*Sniff' => 'Sniff',
    ];

[enumag]

Maybe this should be added.

        '*Exception' => 'Exception',

[TomasVotruba]

@enumag Yes, thanks!
That could replace https://github.com/Symplify/CodingStandard#exception-should-have-suffix-exception

[JanMikes]

I like the idea! It will be useful in my projects as well.

[TomasVotruba]

@lexinek Thanks bro! Any thing to add to the list? CommandHandler maybe?

[JanMikes]

Yeah i was thinking about it, but i think these are more specific and i think more individual. Could be Request, Handler, Response, Repository. For doctrine custom types the Type suffix. Test for PHPUnit testcases and so on 😄 Processor for Sentry processors, Producer and Consumer for rabbit.

There are really alot of them, are you sure you would like to add them all here instead of giving more freedom to users? Because naming conventions can be very different in different companies.

[TomasVotruba]

@lexinek Well, the fixer is customizable, so anyone can use anything they like 🏳️
Thank for the ideas, I missed most of them :). I'll think about it tomorrow and add those most common ones.

[TomasVotruba]

I liked Test, but is not deterministic, because there are 2 options:

• TestCase => Test
• TestCase => TestCase

[TomasVotruba]

I've added support for interface version as well

So EventSubscriber covers also EventSubscriberInterface