eval_mpfr method added

[isuruf]

No description provided.

[certik]

Looks good. I think we should also set the MPFR precision in the upper
level function and use this precision throughout.

Sent from my mobile phone.
On May 25, 2015 6:18 AM, "Isuru Fernando" notifications@github.com wrote:

---

You can view, comment on, or merge this pull request online at:

#456
Commit Summary

• eval_mpfr method added

File Changes

• M CMakeLists.txt
  https://github.com/sympy/symengine/pull/456/files#diff-0 (19)
• M src/CMakeLists.txt
  https://github.com/sympy/symengine/pull/456/files#diff-1 (1)
• A src/eval_mpfr.cpp
  https://github.com/sympy/symengine/pull/456/files#diff-2 (259)
• A src/eval_mpfr.h
  https://github.com/sympy/symengine/pull/456/files#diff-3 (23)
• M src/symengine_config.h.in
  https://github.com/sympy/symengine/pull/456/files#diff-4 (3)

Patch Links:

• https://github.com/sympy/symengine/pull/456.patch
• https://github.com/sympy/symengine/pull/456.diff

—
Reply to this email directly or view it on GitHub
#456.

[isuruf]

I didn't set it because the user could give the precision by initializing mpfr_t in eval_mpfr(mpfr_t result, const Basic &b, mpfr_rnd_t rnd); with the necessary precision.

[certik]

Ah, yes, that's the way to go. Add some tests with various precisions, to make this clear. Now when we have this, we can for example take some more difficult example (I know there is one, where the answer looks like an integer, or 167.99999 to be precise, and then after like 15 digits you get something other than 9). We can evaluate with our eval_double and then check the answer with eval_mpfr as well as show that higher precision provides more accurate result. I'll try to lookup the example.

[Sumith1896]

Does this come as a cmake option?

[isuruf]

@certik, I added a test. Is this what you had in mind? (I'll add more tests)
@Sumith1896 yes, -DWITH_MPFR=yes to enable it or if you have arb, just -DWITH_ARB=yes

[certik]

@isuruf Yes, exactly. I think you need to merge with master, there are some conflicts.

[isuruf]

Merged with master and improved the comments. Please check if I missed something in the comments.

[certik]

This is very good. +1 to merge.