New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while simplifying equations containing csc and sec using trigsimp_groebner #11062

Closed
kirankonduru opened this Issue Apr 29, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@kirankonduru
Copy link

kirankonduru commented Apr 29, 2016

from sympy import *
from sympy.simplify.trigsimp import *
from sympy.abc import x,y
trigsimp_groebner(csc(x) * sin(x))
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\User\AppData\Local\Programs\Python\Python35-32\lib\site-packages\sympy\simplify\trigsimp.py", line 379, in trigsimp_groebner
num = Poly(num, gens=gens+freegens).eject(*gens)
NameError: name 'Poly' is not defined

@parsoyaarihant

This comment has been minimized.

Copy link
Contributor

parsoyaarihant commented Apr 30, 2016

@asmeurer I would like to work on this issue, how do i start?

skirpichev added a commit to diofant/diofant that referenced this issue Apr 30, 2016

parsoyaarihant added a commit to parsoyaarihant/sympy that referenced this issue May 5, 2016

Included test
Added test case for the input which was causing the error in issue
sympy#11062:

‘from sympy import *
from sympy.simplify.trigsimp import *
from sympy.abc import x,y
trigsimp_groebner(csc(x) * sin(x))’

Previously Poly function wasn’t imported in the trigsimp.py file hence
there was an error :
NameError: name 'Poly' is not defined

importing the Poly function in the file solves the problem :)

aktech referenced this issue May 6, 2016

Merge pull request #11067 from parsoyaarihant/patch-for-#11062
imported missing Poly function in trigsimp.py file

skirpichev added a commit to diofant/diofant that referenced this issue May 8, 2016

asmeurer referenced this issue May 12, 2016

Merge pull request #11084 from parsoyaarihant/patch-for-#11062
Enabled commutative property for MatrixElement
@OMantere

This comment has been minimized.

Copy link

OMantere commented May 13, 2016

Shouldn't this be closed?

Shekharrajak added a commit to Shekharrajak/sympy that referenced this issue May 22, 2016

Included test
Added test case for the input which was causing the error in issue
sympy#11062:

‘from sympy import *
from sympy.simplify.trigsimp import *
from sympy.abc import x,y
trigsimp_groebner(csc(x) * sin(x))’

Previously Poly function wasn’t imported in the trigsimp.py file hence
there was an error :
NameError: name 'Poly' is not defined

importing the Poly function in the file solves the problem :)

Shekharrajak added a commit to Shekharrajak/sympy that referenced this issue May 22, 2016

Included test
Added test case for the input which was causing the error in issue
sympy#11062:

‘from sympy import *
from sympy.simplify.trigsimp import *
from sympy.abc import x,y
trigsimp_groebner(csc(x) * sin(x))’

Previously Poly function wasn’t imported in the trigsimp.py file hence
there was an error :
NameError: name 'Poly' is not defined

importing the Poly function in the file solves the problem :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment