New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matrices] remove dead files `densearith.py` `densetools.py` and `densesolve.py` #12695

Open
siefkenj opened this Issue May 31, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@siefkenj
Contributor

siefkenj commented May 31, 2017

It appears that densearith.py densetools.py and densesolve.py are left over from a half-finished project. They are used nowhere in the code base, and glancing at the code, are least the row-reduction algorithm appears to be incorrect.

Those modules have to be imported manually. I propose adding a deprecation warning whenever someone imports them and slate them for removal in sympy 1.2.

@jksuom

This comment has been minimized.

Member

jksuom commented Jun 1, 2017

The commit message of densearith says

Support for gmpy types is being added to the Matrix module in this PR like the Polys module.

This looks like something that is currently planned for all polys domains, not for gmpy types alone. If that is implemented, then this should apparently be deprecated. Maybe a warning would be appropriate now.

@firedranzer

This comment has been minimized.

Contributor

firedranzer commented Jun 16, 2017

@siefkenj Is this issue still open? I would like to work on this issue.

@siefkenj

This comment has been minimized.

Contributor

siefkenj commented Jun 17, 2017

@firedranzer It is! You just need to add a deprecation warning to those files and fix the tests to handle the deprecation warning. You can look at how the deprecated tests in test_matrices.py are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment