Join GitHub today
RisingFactorial cannot do numerical (floating point) evaluations #14822
Expected result: something like
There is an
So probably this is an easy fix: find out how other special functions talk to
I already gave my suggestions about first steps... In a bit more detail:
Please note: if I could really give step-by-step hints I would know how to fix it myself right? ;-)
@cbm755 I got into the code and it turns out that
It also turns out that the issue is only occurring when there's a floating point number as an argument.
Also, other functions (
I'm still working on the floating point correction part.
this is correct. I did find that
added a commit
Jun 22, 2018
When I add it to the evalf_table, would I also be required to add the method corresponding to
referenced this issue
Jul 22, 2018
To fix this issue, I've added _eval_evalf methods to the RisingFactorial and FallingFactorial classes that compute the result using the rf and ff functions in mpmath. I added test cases and created a pull request #14955 referencing this issue.
I've updated the pull request, adding these functions to the evalf_table instead of creating separate _eval_evalf functions.