Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyDy examples need to include the PyDy license #15214

Closed
moorepants opened this issue Sep 11, 2018 · 5 comments · Fixed by #17927
Closed

PyDy examples need to include the PyDy license #15214

moorepants opened this issue Sep 11, 2018 · 5 comments · Fixed by #17927
Labels
Easy to Fix This is a good issue for new contributors. Feel free to work on this if no one else has already. parsing

Comments

@moorepants
Copy link
Member

There is a new directory in sympy/parsing/autolev/tests:

│   ├── pydy-example-repo
│   │   ├── chaos_pendulum.al
│   │   ├── chaos_pendulum.py
│   │   ├── double_pendulum.al
│   │   ├── double_pendulum.py
│   │   ├── __init__.py
│   │   ├── mass_spring_damper.al
│   │   ├── mass_spring_damper.py
│   │   ├── non_min_pendulum.al
│   │   └── non_min_pendulum.py

These examples are copied from PyDy, but the PyDy license isn't included. I don't care personally, but we should probably follow protocol and include the PyDy license.

@moorepants
Copy link
Member Author

@NikhilPappu fyi

@NikhilPappu
Copy link
Contributor

@moorepants Sure, I shall include it.

@moorepants moorepants added the Easy to Fix This is a good issue for new contributors. Feel free to work on this if no one else has already. label Oct 8, 2018
@friyaz
Copy link
Member

friyaz commented Oct 9, 2018

i am not able to find PyDy license ? do you mean including this citation ?

@moorepants
Copy link
Member Author

@NoumbissiValere
Copy link
Contributor

I am interested in working on this issue. is it still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy to Fix This is a good issue for new contributors. Feel free to work on this if no one else has already. parsing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants