Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing NumPy matrix expression printers #17013

Open
anpandey opened this issue Jun 11, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@anpandey
Copy link
Contributor

commented Jun 11, 2019

The NumPyPrinter class currently does not implement the printing of the following matrix expressions which might have corresponding built-in NumPy functions:

  • DiagonalizeVector
  • KroneckerProduct
  • ZeroMatrix
  • OneMatrix
  • FunctionMatrix
  • Adjoint
  • HadamardProduct
  • DiagonalMatrix
  • DiagonalOf
@vighneshq

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I will try and implement these if it's fine.
One question, is DiagonalMatrix going to be removed (see #16682), if so there's no need to write that one in.

@anpandey

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Sure, by all means go ahead! The PR at #17027 starts with stubs of the methods that need to be implemented.

@vighneshq

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

@anpandey I already have a separate branch with some of the functions which would clash with your PR. Is there a way I can instead add you as a coauthor in mine?

Edit : I am not sure how I can extend your PR, else I will just do that.

@vighneshq vighneshq referenced a pull request that will close this issue Jun 14, 2019

Open

Add numpy printing support for some matrix expressions #17029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.