Allow passing of kwargs to theano.function. #2358
Conversation
|
SymPy Bot Summary: ✅ Passed after merging moorepants/unused-arg (8fef999) into master (0bdb41a). |
|
SymPy Bot Summary: ✅ Passed after merging moorepants/unused-arg (8fef999) into master (0bdb41a). |
| def test_theano_function_kwargs(): | ||
| import numpy as np | ||
| f = theano_function([x, y, z], [x+y], dim=1, on_unused_input='ignore') | ||
| assert np.linalg.norm(f([1, 2], [3, 4], [0, 0]) - np.asarray([4, 6])) < 1e-9 |
There was a problem hiding this comment.
So normally would this raise an error?
There was a problem hiding this comment.
Yes, because on_unsused_input is not an arg for dim_handling().
There was a problem hiding this comment.
And you can't pass in more values than specified inputs for theano.function.
|
I need to fix my setup before I can test this. Annoyingly travis isn't set up well to test issues related to Theano. We don't install theano in the travis virtual boxes so all tests are skipped and need to be run locally. |
A variety of small fixes
|
SymPy Bot Summary: ✅ Passed after merging moorepants/unused-arg (6ab3bc0) into master (196fdb3). |
|
I think this is good to go. |
|
Seems fine to me. Merging. |
Allow passing of kwargs to theano.function.
@mrocklin What do you think of this change?