New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minpoly() should use PurePoly #5850

Open
asmeurer opened this Issue Oct 19, 2011 · 2 comments

Comments

Projects
None yet
3 participants
@asmeurer
Copy link
Member

asmeurer commented Oct 19, 2011

minpoly() used to use Pure, but when this was removed, it was made to use a Dummy instead of PurePoly.  This means that the results don't compare equal to each other.

In [1]: minpoly(sqrt(2))
Out[1]: 
 2    
x  - 2

In [2]: type(minpoly(sqrt(2)))
Out[2]: sympy.core.add.Add

In [3]: minpoly(sqrt(2)) == minpoly(sqrt(2))
Out[3]: False

Original issue for #5850: http://code.google.com/p/sympy/issues/detail?id=2751
Original author: https://code.google.com/u/asmeurer@gmail.com/
Original owner: https://code.google.com/u/asmeurer@gmail.com/

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Mar 20, 2012

@smichr

This comment has been minimized.

Copy link
Member

smichr commented Apr 19, 2013

Although death of dummy_eq has been called for, it can be used for this:

>>> minpoly(sqrt(2)).dummy_eq(minpoly(sqrt(2)))
True

Original comment: http://code.google.com/p/sympy/issues/detail?id=2751#c2
Original author: https://code.google.com/u/117933771799683895267/

@asmeurer asmeurer self-assigned this Mar 7, 2014

skirpichev added a commit to skirpichev/diofant that referenced this issue Mar 13, 2018

skirpichev added a commit to skirpichev/diofant that referenced this issue Mar 14, 2018

skirpichev added a commit to skirpichev/diofant that referenced this issue Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment