New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo after issues migration #7235

Closed
skirpichev opened this Issue Mar 7, 2014 · 45 comments

Comments

Projects
None yet
4 participants
@skirpichev
Contributor

skirpichev commented Mar 7, 2014

Right now, the transfer of issues from the SymPy googlecode project is complete.

Here is some summary. Before we did issue transfer, the last issue was #3006 and the last pr was #3005, the last merged in pr: #2927. New (moved) issues ("imported" label) have numbers, starting from #3100 (that's issue 1 on the google code). The last imported issue number: #7233.

So, issue numbers are shifted (same for milestones, but this is less important).

  • Fix labels (@asmeurer, can you do this?) and, probably, milestone names
  • Shift issue numbering in the source code.
    Some examples:
    • references like issue 1234
    • or issue #1234
    • or even #1234 (?)
    • @deprecated(..., issue=1234, ...)
    • test functions like def test_issues_1234() or def test_1234(). But remember, we have github's issues too, so there is def test_gh_issue_2877(), for example...
  • Remove old labels (like code-in), and just add a comment here listing the issues that had them, in case we do code-in again. you only need to do that for the code-in labels that have open issues. Just delete the username labels.
    • ??

Please post in the comments if you want to mention some problem with imported issues.

PS: Probably, right now we can merge sympy/sympy.github.com#70 and close issue #2824.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 7, 2014

@skirpichev skirpichev self-assigned this Mar 7, 2014

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 7, 2014

  • we also need to see if be can post comments on old issues with a link to the new issue. If not, we should at least add a comment saying "add 3100" to all issues.
@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 7, 2014

see #7238

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 8, 2014

Sometimes pre-formatted text in old issues looks pretty ugly. I think we should encourage developers to edit old issues and fix this.

Lets introduce some convention (e.g. to help our scripts in the future): if you are going to modify old issue text or it's commentary - please remove original text up to line "Original issue" (or "Original comments") and then reintroduce new text at the bottom.

@asmeurer, what do you think about?

we also need to see if be can post comments on old issues with a link to the new issue. If not, we should at least add a comment saying "add 3100" to all issues.

I'm a little lazy here. Lets do this in a simplest way. But please note, that a comment should look "add 3099".

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 8, 2014

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 10, 2014

Yes, I agree completely.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 10, 2014

Lets introduce some convention (e.g. to help our scripts in the future): if you are going to modify old issue text or it's commentary - please remove original text up to line "Original issue" (or "Original comments") and then reintroduce new text at the bottom.

I completely agree. The preformatted comments look really bad.

For me, this is motivation to close all imported issues.

I'm a little lazy here. Lets do this in a simplest way. But please note, that a comment should look "add 3099".

Oh. So we should have started at 2999 :)

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 10, 2014

https://github.com/sympy-issue-migrator should be excluded from the sympy team?

Thanks for reminding me. This user needs to keep on existing, though, or else the commenter will turn into a ghost.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 10, 2014

I'm a little lazy here

Are you too lazy to do the bulk edit? You have to do around 200 at a time (edit the url), because more than that gives an error. I've given you access to comment on issues if you want to do it. You can bulk edit in the popup at the top of the issue list. Or if anyone else wants to do it, or take a shot at writing a script to do links to the actual imported issue, let me know.

By the way, I realized that there is no way to force prevent someone who goes to https://code.google.com/p/sympy/issues/entry? from opening a new issue. They'd have to blatantly ignore the text there, though, so it's not a huge issue.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 10, 2014

I added another todo at the top.

asmeurer added a commit that referenced this issue Mar 12, 2014

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 12, 2014

Ok. Issue numbers in the codebase now should point to github's issues (please report problems here if any). Please be careful while merging new PR (i.e. after #7238).

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 13, 2014

Problem: reference #5641 - doesn't work in the commentary

Fixed.

I added another todo at the top.
... Remove old labels (like code-in), and just add a comment here listing the issues that had them, in case we do code-in again. you only need to do that for the code-in labels that have open issues.

Code-In*:
#5888 #5889 #5895 #5897 #5898 #5259 #5526 #6551 #5871 #5916 #5627 #6562 #6563 #6564 #6565 #6566 #6567 #6568 #5929 #5418 #6571 #5214 #4917 #5686 #5944 #5948 #5693 #6570 #3393 #5899 #6596 #5958 #4555 #5963 #5967 #3281 #5971 #6101 #4985 #5987 #5982 #5669 #5731 #5862 #5863 #6588 #5867 #5868 #4334 #5885 #6086 #6009 #6572 #6012 #5629 #5375.

Just delete the username labels. ...

Done.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 27, 2014

ok, here is a script to add links for issues:
https://github.com/skirpichev/google-code-issues-migrator/blob/my2/mark-moved.py

Sample run (up to id=5):

$ python ./mark-moved.py --end-at=5 --issues-start-from=3100 --google-project='sympy' --google-username='skirpichev'
Password: 
Migrating 1
Created http://github.com/sympy/sympy/issues/3100
Migrating 2
Created http://github.com/sympy/sympy/issues/3101
Migrating 3
Created http://github.com/sympy/sympy/issues/3102
Migrating 4
Created http://github.com/sympy/sympy/issues/3103
Migrating 5
Created http://github.com/sympy/sympy/issues/3104

Comment examples:
http://code.google.com/p/sympy/issues/detail?id=1#c4
http://code.google.com/p/sympy/issues/detail?id=3#c26

@asmeurer, if everything is ok - I will run this script on the whole database of issues.

BTW, what about the first todo item (fix labels/milestones)? This task is completed?

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 27, 2014

If it's possible to mark issues without sending notifications (e.g., there is a box for this in the bulk edit form) that would be preferable. But if there isn't, then don't worry about it.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 27, 2014

I'm not sure. Lets do test that.
http://code.google.com/p/sympy/issues/detail?id=6

@asmeurer, @certik, did you receive any notifications?

@certik

This comment has been minimized.

Member

certik commented Mar 27, 2014

Yes, I did receive few notifications.

Ondrej

On Thu, Mar 27, 2014 at 9:33 AM, Sergey B Kirpichev <
notifications@github.com> wrote:

I'm not sure. Lets do test that.
http://code.google.com/p/sympy/issues/detail?id=6

@asmeurer https://github.com/asmeurer, @certikhttps://github.com/certik,
did you receive any notifications?


Reply to this email directly or view it on GitHubhttps://github.com//issues/7235#issuecomment-38819100
.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 27, 2014

On Thu, Mar 27, 2014 at 08:36:34AM -0700, Ondřej Čertík wrote:

Yes, I did receive few notifications.

Maybe there is a way to switch off all notifications? I
don't know how to do this with gdata API, if possible at all.

@certik

This comment has been minimized.

Member

certik commented Mar 27, 2014

In the settings I can turn it off:

Issue tracker
Hovering over an ID in the issue list opens a preview window.

Whenever an issue is changed by another user, send me an email:
If I am in the issue's owner or CC fields.
If I starred the issue. 

But all other people will still get it, unfortunately.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 27, 2014

Maybe the notification only went to the issues list?

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 27, 2014

Maybe the notification only went to the issues list?

Did you receive something (you are in Cc for that bug)?

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 27, 2014

Oh yes, it looks like I did.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 28, 2014

@certik, @asmeurer how about this time? Did you receive comment notification about
http://code.google.com/p/sympy/issues/detail?id=6#c25

@skirpichev skirpichev removed the Easy to Fix label Mar 28, 2014

@certik

This comment has been minimized.

Member

certik commented Mar 29, 2014

I didn't. Only into the sympy-issues mailinglist at Google groups, but not
into my personal gmail inbox.

What did you do differently?

Ondrej

On Fri, Mar 28, 2014 at 4:34 AM, Sergey B Kirpichev <
notifications@github.com> wrote:

@certik https://github.com/certik, @asmeurerhttps://github.com/asmeurerhow about this time? Did you receive comment notification about
http://code.google.com/p/sympy/issues/detail?id=6#c25


Reply to this email directly or view it on GitHubhttps://github.com//issues/7235#issuecomment-38905944
.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 29, 2014

Ondrej, why did you receive it before? Do you have the issue starred?

I did receive the comment, but I am CCd. If it still bugs people who are CCd but not people who are starred, that's a reasonable workaround (and we can always remove CCs first too).

@certik

This comment has been minimized.

Member

certik commented Mar 29, 2014

I don't know why I received it before.

On Sat, Mar 29, 2014 at 11:50 AM, Aaron Meurer notifications@github.comwrote:

Ondrej, why did you receive it before? Do you have the issue starred?

I did receive the comment, but I am CCd. If it still bugs people who are
CCd but not people who are starred, that's a reasonable workaround (and we
can always remove CCs first too).


Reply to this email directly or view it on GitHubhttps://github.com//issues/7235#issuecomment-39003100
.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 30, 2014

What did you do differently?

Essentially, nothing. But this time I didn't change CC list (see comment #c23) and bug status.

@certik

This comment has been minimized.

Member

certik commented Mar 30, 2014

I see. I think I am ok with simply adding the link to the github issue for all the issues. I'll handle it somehow, Aaron as well. And most other people will only get notifications for bugs that they reported, which should be fine. What do you think?

@asmeurer

This comment has been minimized.

Member

asmeurer commented Mar 30, 2014

It's fine with me.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Mar 31, 2014

Clearly, we have "Send email" in the comment form - so, it's possible to hack gdata to use this option. But it doesn't support this natively.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 2, 2014

I'm giving up. It seems, there is no easy way to switch off these notifications (for bug owner and cc list members) with gdata api.

Shall I proceed with adding comments for the whole database of issues with the current script, or we can postpone this task? @asmeurer, @certik ?

@asmeurer

This comment has been minimized.

Member

asmeurer commented Apr 2, 2014

I would send a warning email to the mailing list, then wait maybe 24 hours, then do it. You can also remove all CCs before sending the emails, right?

@certik

This comment has been minimized.

Member

certik commented Apr 2, 2014

I agree with Aaron.

On Wed, Apr 2, 2014 at 8:36 AM, Aaron Meurer notifications@github.comwrote:

I would send a warning email to the mailing list, then wait maybe 24
hours, then do it. You can also remove all CCs before sending the emails,
right/


Reply to this email directly or view it on GitHubhttps://github.com//issues/7235#issuecomment-39337700
.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 2, 2014

You can also remove all CCs before sending the emails, right?

This is possible, but it's far from trivial. The tricky part is how to get Cc list.

But it may be doable with bulk edit (there is ~200 issues with Cc set, not too much).

@certik

This comment has been minimized.

Member

certik commented Apr 2, 2014

Besides the ~200 issues (which is nothing imho), nobody will get any notifications?

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 2, 2014

I think, issue owner. I got notification here:
https://code.google.com/p/skirpichev/issues/detail?id=1#c3

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 3, 2014

I would send a warning email to the mailing list, then wait maybe 24 hours, then do it.

https://groups.google.com/d/msg/sympy/3fblubiXUyU/WYi6Pk3FZAoJ

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 5, 2014

  • add "Need Decision" label for issues with such a status on gcode
@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 6, 2014

Everything is done, except labels/milestones renaming. @asmeurer, can we close this issue?

@asmeurer

This comment has been minimized.

Member

asmeurer commented Apr 6, 2014

Great. I got a lot of messages like "Your project notifications generated too many emails to send
individually. Here are the subject lines of the emails you would have
received:" for a hundred issues at a time, so the impact on my email wasn't terrible.

@asmeurer asmeurer closed this Apr 6, 2014

@certik

This comment has been minimized.

Member

certik commented Apr 8, 2014

I didn't get anything.

On Sun, Apr 6, 2014 at 9:25 AM, Aaron Meurer notifications@github.comwrote:

Great. I got a lot of messages like "Your project notifications generated
too many emails to send
individually. Here are the subject lines of the emails you would have
received:" for a hundred issues at a time, so the impact on my email
wasn't terrible.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7235#issuecomment-39671180
.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Apr 8, 2014

I also didn't get anything.

@asmeurer

This comment has been minimized.

Member

asmeurer commented Apr 8, 2014

I never disabled the settings in my google code.

@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Jun 9, 2014

I miss "def foo_bar_issue[0-9]+():" pattern.

@skirpichev skirpichev reopened this Jun 9, 2014

smichr added a commit that referenced this issue Jun 10, 2014

Merge pull request #7579 from skirpichev/shift-issue-numbers2
Shift issue numbers in strings like issue([0-9]+), closes #7235
@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Jul 8, 2014

The pattern "issues [0-9]+": #7706

smichr added a commit to smichr/sympy that referenced this issue Jul 8, 2014

update issue numbers in some tests [skip ci]
See original issue describing the issues migration
at sympy#7235
@skirpichev

This comment has been minimized.

Contributor

skirpichev commented Oct 21, 2014

#8286: patterns bug 123, bug #123, def test_bug123.

@skirpichev skirpichev removed their assignment Apr 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment