New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of lambdify converting `Matrix` -> `numpy.matrix` #7853

Closed
jcrist opened this Issue Aug 11, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@jcrist
Copy link
Member

jcrist commented Aug 11, 2014

This issue is for documenting the deprecation cycle for the default behavior of lambdify to convert Matrix to numpy.matrix. Per the numpy devs, array is always preferable to matrix, and many scipy functions only work with array. To avoid breaking code after the release, the following deprecation cycle will be observed:

  1. Prior to release of 0.7.6 (versions up to and including 0.7.5) lambdify converted Matrix to numpy.matrix by default.
  2. In 0.7.6, expressions that contain Matrices throw a SymPyDeprecationWarning warning the user of the upcoming change. The user is advised to set modules=[{'ImmutableMatrix': numpy.array}, 'numpy'], which will avoid the deprecation warning and result in Matrix->array. If they will be using lambdify often, a recommendation to apply functools.partial to set the kwarg permanently is also given.
  3. For the release of 0.7.7, Matrix -> array will be the new behavior.

The modules kwarg is set to [{'ImmutableMatrix': numpy.array}, 'numpy'] for some uses of lambdify internally. For the release of 0.7.7 the use of modules in this case should be reverted.

For more rational on why this change was made, see #7284, and the implementing PR #8034.

@jcrist jcrist added this to the 0.7.7 milestone Aug 11, 2014

richardotis added a commit to richardotis/sympy that referenced this issue Jul 12, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

richardotis added a commit to richardotis/sympy that referenced this issue Jul 12, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.
@richardotis

This comment has been minimized.

Copy link
Contributor

richardotis commented Jul 13, 2015

#9657 resolves this issue.

skirpichev added a commit to diofant/diofant that referenced this issue Aug 30, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

Conflicts:
	sympy/utilities/lambdify.py
	sympy/utilities/tests/test_lambdify.py

skirpichev added a commit to diofant/diofant that referenced this issue Sep 13, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

Conflicts:
	sympy/utilities/lambdify.py
	sympy/utilities/tests/test_lambdify.py

skirpichev added a commit to diofant/diofant that referenced this issue Sep 16, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

Conflicts:
	sympy/utilities/lambdify.py
	sympy/utilities/tests/test_lambdify.py

skirpichev added a commit to diofant/diofant that referenced this issue Sep 28, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

skirpichev added a commit to diofant/diofant that referenced this issue Sep 30, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.

skirpichev added a commit to diofant/diofant that referenced this issue Sep 30, 2015

Adds NumPyPrinter to lambdify for dealing with piecewise functions, m…
…atrix multiplication and logical operators. Ends deprecation cycle started by sympy/sympy#7853 so that ImmutableMatrix now maps to numpy.array by default.
@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Oct 26, 2015

Closing this issue, since the deprecated feature was removed.

@asmeurer asmeurer closed this Oct 26, 2015

skirpichev added a commit to skirpichev/diofant that referenced this issue Nov 2, 2016

Add regression tests & mention closed issues
    close sympy/sympy#3112 (MrvAsympt was added in diofant#6)
    close sympy/sympy#9173 (test was added in 5a510ac)
    close sympy/sympy#9808 (fixed in 09e539b)
    close sympy/sympy#9341 (fixed in af98a00)
    close sympy/sympy#9908 (fixed in cc3fa8d)
    close sympy/sympy#6171 (test added in d278031)
    close sympy/sympy#9276 (diagnose_imports.py removed in ab8c535)
    close sympy/sympy#10201 (fixed in 0d0fc5f)
    close sympy/sympy#9057 (test was added in 8290a0c)
    close sympy/sympy#11159 (test was added in ffb76cb)
    close sympy/sympy#2839 (new AST transformers are used, see diofant#278 and diofant#167)
    close sympy/sympy#11081 (see ed01e16 and bb92329)
    close sympy/sympy#10974 (see 73fc425)
    close sympy/sympy#10806 (test in 539929a)
    close sympy/sympy#10801 (test in 2fe3da5)
    close sympy/sympy#9549 (test in 88bdefa)
    close sympy/sympy#4231 (test was added in fb411d5)
    close sympy/sympy#8634 (see 2fcbb58)
    close sympy/sympy#8481 (see 1ef20d3)
    close sympy/sympy#9956 (fixed in a34735f)
    close sympy/sympy#9747 (see e117c60)
    close sympy/sympy#7853 (see 3e4fbed)
    close sympy/sympy#9634 (see 2be03f5)
    close sympy/sympy#8500 (fixed in diofant#104 and finally in diofant#316)
    close sympy/sympy#9192 (see 9bf622f)
    close sympy/sympy#7130 (see e068fa3)
    close sympy/sympy#8514 (see b2d543b)
    close sympy/sympy#9334 (see 90de625)
    close sympy/sympy#8229 (see 9755b89)
    close sympy/sympy#8061 (see 7054f06)
    close sympy/sympy#7872 (tested in diofant#6)
    close sympy/sympy#3496 (tested in test_log_symbolic)
    close sympy/sympy#2929 (see da7db7a)
    close sympy/sympy#8203 (oo is not a real, see diofant#36)
    close sympy/sympy#7649 (0 is imaginary since diofant#8)
    close sympy/sympy#7256 (fixed in c0a4549)
    close sympy/sympy#6783 (see cb28d63)
    close sympy/sympy#5662 (is_integer issue fixed in 6bfa9f8, there is no is_bounded anymore)
    close sympy/sympy#5295 (fixed with diofant#354)
    close sympy/sympy#4856 (we now have flake/pep tests)
    close sympy/sympy#4555 (flake8 enabled after diofant#214)
    close sympy/sympy#5773 (cmp_to_key removed after diofant#164 and c9acbf0)
    close sympy/sympy#5484 (see above)

    Added regression tests:
    from https://groups.google.com/forum/#!topic/sympy/LkTMQKC_BOw
    fixes sympy/sympy#8825 (probably via diofant#209)
    fixes sympy/sympy#8635
    fixes sympy/sympy#8157
    fixes sympy/sympy#7872
    fixes sympy/sympy#7599
    fixes sympy/sympy#6179
    fixes sympy/sympy#5415
    fixes sympy/sympy#2865
    fixes sympy/sympy#5907
    fixes sympy/sympy#11722

    Closes diofant#347

skirpichev added a commit to skirpichev/diofant that referenced this issue Nov 2, 2016

Add regression tests & mention closed issues
    close sympy/sympy#3112 (MrvAsympt was added in diofant#6)
    close sympy/sympy#9173 (test was added in 5a510ac)
    close sympy/sympy#9808 (fixed in 09e539b)
    close sympy/sympy#9341 (fixed in af98a00)
    close sympy/sympy#9908 (fixed in cc3fa8d)
    close sympy/sympy#6171 (test added in d278031)
    close sympy/sympy#9276 (diagnose_imports.py removed in ab8c535)
    close sympy/sympy#10201 (fixed in 0d0fc5f)
    close sympy/sympy#9057 (test was added in 8290a0c)
    close sympy/sympy#11159 (test was added in ffb76cb)
    close sympy/sympy#2839 (new AST transformers are used, see diofant#278 and diofant#167)
    close sympy/sympy#11081 (see ed01e16 and bb92329)
    close sympy/sympy#10974 (see 73fc425)
    close sympy/sympy#10806 (test in 539929a)
    close sympy/sympy#10801 (test in 2fe3da5)
    close sympy/sympy#9549 (test in 88bdefa)
    close sympy/sympy#4231 (test was added in fb411d5)
    close sympy/sympy#8634 (see 2fcbb58)
    close sympy/sympy#8481 (see 1ef20d3)
    close sympy/sympy#9956 (fixed in a34735f)
    close sympy/sympy#9747 (see e117c60)
    close sympy/sympy#7853 (see 3e4fbed)
    close sympy/sympy#9634 (see 2be03f5)
    close sympy/sympy#8500 (fixed in diofant#104 and finally in diofant#316)
    close sympy/sympy#9192 (see 9bf622f)
    close sympy/sympy#7130 (see e068fa3)
    close sympy/sympy#8514 (see b2d543b)
    close sympy/sympy#9334 (see 90de625)
    close sympy/sympy#8229 (see 9755b89)
    close sympy/sympy#8061 (see 7054f06)
    close sympy/sympy#7872 (tested in diofant#6)
    close sympy/sympy#3496 (tested in test_log_symbolic)
    close sympy/sympy#2929 (see da7db7a)
    close sympy/sympy#8203 (oo is not a real, see diofant#36)
    close sympy/sympy#7649 (0 is imaginary since diofant#8)
    close sympy/sympy#7256 (fixed in c0a4549)
    close sympy/sympy#6783 (see cb28d63)
    close sympy/sympy#5662 (is_integer issue fixed in 6bfa9f8, there is no is_bounded anymore)
    close sympy/sympy#5295 (fixed with diofant#354)
    close sympy/sympy#4856 (we now have flake/pep tests)
    close sympy/sympy#4555 (flake8 enabled after diofant#214)
    close sympy/sympy#5773 (cmp_to_key removed after diofant#164 and c9acbf0)
    close sympy/sympy#5484 (see above)

    Added regression tests:
    from https://groups.google.com/forum/#!topic/sympy/LkTMQKC_BOw
    fixes sympy/sympy#8825 (probably via diofant#209)
    fixes sympy/sympy#8635
    fixes sympy/sympy#8157
    fixes sympy/sympy#7872
    fixes sympy/sympy#7599
    fixes sympy/sympy#6179
    fixes sympy/sympy#5415
    fixes sympy/sympy#2865
    fixes sympy/sympy#5907
    fixes sympy/sympy#11722

    Closes diofant#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment