Fixed Issue UserWarning plot3d #10612 #10811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plot3d was generating a warning and and exception for atan2() because vectorized_lambdify was not able to translate this function into numpy
|
Use whitespace after Could you please add a test as well for the fix. |
|
@debugger22 Yes, I will do that ! Thanks :) |
|
@debugger22 Can you guide me with the test case for this pull request ? There is no test_experimental_lambdify , should I create one?? |
|
My preference in hard to test cases is to take your word that something that failed before now works. If there is no objection I will commit this in a day or so. |
|
Can you explain how this fixes the issue? Also, you can add a test for the plot itself in the plotting tests. |
gxyd
added
plotting
PR: author's turn
|
@sanyagithub can you please address the requested comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plot3d was generating a warning and and exception for atan2()
because vectorized_lambdify was not able to translate this function
into numpy
fixes #10612