New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace has_Field/Ring with is_Field/Ring #12719

Merged
merged 4 commits into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@valglad
Contributor

valglad commented Jun 8, 2017

Replace has_Field and has_Ring attributes of domains with is_Field, is_Ring.

@jksuom

This comment has been minimized.

Show comment
Hide comment
@jksuom

jksuom Jun 9, 2017

Member

There remains has_Field in sympy/polys/domains/field.py.

Member

jksuom commented Jun 9, 2017

There remains has_Field in sympy/polys/domains/field.py.

@jksuom

This comment has been minimized.

Show comment
Hide comment
@jksuom

jksuom Jun 9, 2017

Member

Some information about deprecation should be added. Wiki suggests that there should be also issue and deprecated_since_version, The version could be 1.1. Opening an issue with Deprecation Removal tag could also be useful as a place to record that the pickling tests were modified. Those tests can then be restored when the issue is closed. A deprecation note should also be added to the release notes.

Member

jksuom commented Jun 9, 2017

Some information about deprecation should be added. Wiki suggests that there should be also issue and deprecated_since_version, The version could be 1.1. Opening an issue with Deprecation Removal tag could also be useful as a place to record that the pickling tests were modified. Those tests can then be restored when the issue is closed. A deprecation note should also be added to the release notes.

@valglad

This comment has been minimized.

Show comment
Hide comment
@valglad

valglad Jun 9, 2017

Contributor

Wiki suggests that there should be also issue

So I need to open an issue with Deprecation Removal tag where I say that the new names make more sense?

Contributor

valglad commented Jun 9, 2017

Wiki suggests that there should be also issue

So I need to open an issue with Deprecation Removal tag where I say that the new names make more sense?

@valglad

This comment has been minimized.

Show comment
Hide comment
@valglad

valglad Jun 9, 2017

Contributor

I'll add a deprecation note to the release notes after the PR is merged.

Contributor

valglad commented Jun 9, 2017

I'll add a deprecation note to the release notes after the PR is merged.

@jksuom

This comment has been minimized.

Show comment
Hide comment
@jksuom

jksuom Jun 9, 2017

Member

I think the deprecation removal issue need not necessarily explain the reason for the change. Only it would be a convenient reminder of the temporary change in the pickling test. It is ok to edit release notes later.

Member

jksuom commented Jun 9, 2017

I think the deprecation removal issue need not necessarily explain the reason for the change. Only it would be a convenient reminder of the temporary change in the pickling test. It is ok to edit release notes later.

@valglad

This comment has been minimized.

Show comment
Hide comment
@valglad

valglad Jun 9, 2017

Contributor

deprecation issue #12723

Contributor

valglad commented Jun 9, 2017

deprecation issue #12723

@jksuom jksuom merged commit a43c914 into sympy:master Jun 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@valglad valglad deleted the valglad:change_is_to_has branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment