New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing curvilinear coordinate system in Vector module #12720

Merged
merged 12 commits into from Jun 13, 2017

Conversation

Projects
None yet
2 participants
@szymag
Contributor

szymag commented Jun 8, 2017

This PR create lamecoeff.py file which store information about Lame coefficient.

Class CoordSysCartesian now has information about Lame coefficient and transformation equations.

Implementation of Lame coefficient.
First approach. Add lamecoeff.py file.
Add basic test. Adapt contructor in
CoordSysCartesian.
@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jun 5, 2017

can this one be an instance of the class?

Upabjojr commented on sympy/vector/lamecoeff.py in dff9828 Jun 5, 2017

can this one be an instance of the class?

@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jun 5, 2017

Why do we need so many classes? I think we do all of this with only one class.

Upabjojr commented on sympy/vector/__init__.py in dff9828 Jun 5, 2017

Why do we need so many classes? I think we do all of this with only one class.

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jun 5, 2017

Owner

OK. I will change structure to store information about systems in one class.

Owner

szymag replied Jun 5, 2017

OK. I will change structure to store information about systems in one class.

@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jun 5, 2017

Why does this inherit Expr? Is it meant to be an expression element? I think it shouldn't.

Upabjojr commented on sympy/vector/lamecoeff.py in dff9828 Jun 5, 2017

Why does this inherit Expr? Is it meant to be an expression element? I think it shouldn't.

szymag added some commits Jun 8, 2017

Simplify in lamecoeff.py
Create only one class which store information
about Lame coefficient.
Lame parameters moves to the end of constructor.
Clean up in CoeffPRovider and CoordSysCartesian.
Add test to test_args.py
Show outdated Hide outdated sympy/vector/coordsysrect.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
@@ -14,7 +15,7 @@ class CoordSysCartesian(Basic):
"""

This comment has been minimized.

@Upabjojr

Upabjojr Jun 9, 2017

Contributor

This class could be renamed CoordSys3D. For compatibility purposed, add a function with called CoordSysCartesian that later calls CoordSys3D

@Upabjojr

Upabjojr Jun 9, 2017

Contributor

This class could be renamed CoordSys3D. For compatibility purposed, add a function with called CoordSysCartesian that later calls CoordSys3D

This comment has been minimized.

@szymag

szymag Jun 9, 2017

Contributor

I will do it at the end or even in another PR. It introduces many changes in docstring so it mess up the code.

@szymag

szymag Jun 9, 2017

Contributor

I will do it at the end or even in another PR. It introduces many changes in docstring so it mess up the code.

This comment has been minimized.

@Upabjojr

Upabjojr Jun 9, 2017

Contributor

OK

@Upabjojr

Upabjojr Jun 9, 2017

Contributor

OK

Show outdated Hide outdated sympy/vector/lamecoeff.py
Remove transformation equation from constructor.
At that moment coordinate system can be created
only using Lame coefficient.
@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jun 9, 2017

Contributor

The reason why I create _equation_mapping and _coefficient_mapping as a methods is access to objects in constructor. I create equations and coefficients using base scalars.

Contributor

szymag commented Jun 9, 2017

The reason why I create _equation_mapping and _coefficient_mapping as a methods is access to objects in constructor. I create equations and coefficients using base scalars.

Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py
Show outdated Hide outdated sympy/vector/lamecoeff.py

@Upabjojr Upabjojr merged commit b66fead into sympy:master Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@szymag szymag deleted the szymag:lame_coefficient branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment