New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differential operators handle different type of coordinate systems. #12737

Merged
merged 7 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@szymag
Contributor

szymag commented Jun 12, 2017

This PR modifies behavior of differential operators in vector module.

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jun 12, 2017

Contributor

ping @Upabjojr

Contributor

szymag commented Jun 12, 2017

ping @Upabjojr

@szymag szymag changed the title from Differential operators handle different type of coordinate systems. to [WIP] Differential operators handle different type of coordinate systems. Jun 14, 2017

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jun 14, 2017

Contributor

@Upabjojr, this commit change some behavior in calculation, so we need to discuss some corner cases.
Previously, information about system, were taken from Del operator (see sympy/vector/vector:110 line), so we could put to gradient int or to curl Vector.zero. Now, it is impossible, because neither delop nor Vector.zero has information about coordinate system.
We can withdraw from removing information from Del class, or we can evaluate such expression, because now the problem is mainly with unevaluated expression. See commented tests in sympy/vector/tests/test_field_functions.py:23:27;85:87

Contributor

szymag commented Jun 14, 2017

@Upabjojr, this commit change some behavior in calculation, so we need to discuss some corner cases.
Previously, information about system, were taken from Del operator (see sympy/vector/vector:110 line), so we could put to gradient int or to curl Vector.zero. Now, it is impossible, because neither delop nor Vector.zero has information about coordinate system.
We can withdraw from removing information from Del class, or we can evaluate such expression, because now the problem is mainly with unevaluated expression. See commented tests in sympy/vector/tests/test_field_functions.py:23:27;85:87

Show outdated Hide outdated sympy/vector/functions.py
Show outdated Hide outdated sympy/vector/__init__.py
Show outdated Hide outdated sympy/vector/deloperator.py
Show outdated Hide outdated sympy/vector/deloperator.py
Show outdated Hide outdated sympy/vector/operators.py
Show outdated Hide outdated sympy/vector/operators.py
Show outdated Hide outdated sympy/vector/tests/test_field_functions.py
Show outdated Hide outdated sympy/vector/tests/test_field_functions.py
Show outdated Hide outdated sympy/vector/tests/test_field_functions.py
Update Lame coefficient inside Del operator.
_set_lame_coefficient_mapping now updates Lame coefficient
also Del operator.

@szymag szymag changed the title from [WIP] Differential operators handle different type of coordinate systems. to Differential operators handle different type of coordinate systems. Jun 15, 2017

@Upabjojr Upabjojr merged commit e780a06 into sympy:master Jun 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@szymag szymag deleted the szymag:scal_factor_operators branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment