New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #12871

Merged
merged 14 commits into from Jul 4, 2017

Conversation

Projects
None yet
3 participants
@szymag
Contributor

szymag commented Jul 2, 2017

Remove information about correlation between Del() and CoordSys3D.

I also update information about calculating directional derivative. It wasn't done after merging this PR: #12417

Closes #12760

@@ -10,7 +10,16 @@
SpaceOrienter, QuaternionOrienter)
class CoordSysCartesian(Basic):
def CoordSysCartesian(*args, **kwargs):
SymPyDeprecationWarning(

This comment has been minimized.

@asmeurer

asmeurer Jul 2, 2017

Member

This needs a deprecation issue.

@asmeurer

asmeurer Jul 2, 2017

Member

This needs a deprecation issue.

This comment has been minimized.

@szymag

szymag Jul 2, 2017

Contributor

I have already done it: #12865

@szymag

szymag Jul 2, 2017

Contributor

I have already done it: #12865

This comment has been minimized.

@asmeurer

asmeurer Jul 2, 2017

Member

It needs to be specified as the issue argument. This is a required argument now in the 1.1 branch.

@asmeurer

asmeurer Jul 2, 2017

Member

It needs to be specified as the issue argument. This is a required argument now in the 1.1 branch.

This comment has been minimized.

@asmeurer

asmeurer Jul 2, 2017

Member

Also please add it to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.1 (and add any other changes you know of for this release to that document).

@asmeurer

asmeurer Jul 2, 2017

Member

Also please add it to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.1 (and add any other changes you know of for this release to that document).

This comment has been minimized.

@szymag

szymag Jul 3, 2017

Contributor

Also please add it to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.1 (and add any other changes you know of for this release to that document).

I added information to release notes for every changes which I made in vector module.

It needs to be specified as the issue argument. This is a required argument now in the 1.1 branch.

I don't understand. Could you explain what means "issue argument"?

@szymag

szymag Jul 3, 2017

Contributor

Also please add it to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.1 (and add any other changes you know of for this release to that document).

I added information to release notes for every changes which I made in vector module.

It needs to be specified as the issue argument. This is a required argument now in the 1.1 branch.

I don't understand. Could you explain what means "issue argument"?

This comment has been minimized.

@szymag

szymag Jul 3, 2017

Contributor

I don't understand. Could you explain what means "issue argument"?

Never mind. I saw how to do it in another PR.

@szymag

szymag Jul 3, 2017

Contributor

I don't understand. Could you explain what means "issue argument"?

Never mind. I saw how to do it in another PR.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Jul 2, 2017

Member

This is coming in very late. It might need to wait until after the first release candidate.

Member

asmeurer commented Jul 2, 2017

This is coming in very late. It might need to wait until after the first release candidate.

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 2, 2017

Contributor

This is coming in very late. It might need to wait until after the first release candidate.

I didn't suspect that 1.1 version will be ready so fast.

Contributor

szymag commented Jul 2, 2017

This is coming in very late. It might need to wait until after the first release candidate.

I didn't suspect that 1.1 version will be ready so fast.

@asmeurer asmeurer added this to the SymPy 1.1 milestone Jul 2, 2017

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Jul 2, 2017

Member

I didn't suspect that 1.1 version will be ready so fast.

Well we have a hard deadline, the codegen tutorial at the SciPy conference (a week from Monday). So the final version needs to go out sometime this next week.

Member

asmeurer commented Jul 2, 2017

I didn't suspect that 1.1 version will be ready so fast.

Well we have a hard deadline, the codegen tutorial at the SciPy conference (a week from Monday). So the final version needs to go out sometime this next week.

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 3, 2017

Contributor

Travis failed on this lines. I suppose that this test shouldn't throw exception. Moreover it didn't when these commits where in master.

def test_coordsys3d():
    with warnings.catch_warnings():
        warnings.filterwarnings("ignore", category=SymPyDeprecationWarning)
        assert CoordSysCartesian("C") == CoordSys3D("C")

ping @moorepants

Contributor

szymag commented Jul 3, 2017

Travis failed on this lines. I suppose that this test shouldn't throw exception. Moreover it didn't when these commits where in master.

def test_coordsys3d():
    with warnings.catch_warnings():
        warnings.filterwarnings("ignore", category=SymPyDeprecationWarning)
        assert CoordSysCartesian("C") == CoordSys3D("C")

ping @moorepants

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 3, 2017

Contributor

Now it works, strange.

Contributor

szymag commented Jul 3, 2017

Now it works, strange.

@@ -16,7 +16,7 @@ def __new__(cls, system=None):
feature="delop operator inside coordinate system",
useinstead="it as instance Del class",
deprecated_since_version="1.1",
issue=12858,

This comment has been minimized.

@asmeurer

asmeurer Jul 3, 2017

Member

There may have been some mixup here. This issue was supposed to say "vector" not "tensor". Since you already opened the other one with more information, should #12858 be closed?

@asmeurer

asmeurer Jul 3, 2017

Member

There may have been some mixup here. This issue was supposed to say "vector" not "tensor". Since you already opened the other one with more information, should #12858 be closed?

This comment has been minimized.

@asmeurer

asmeurer Jul 3, 2017

Member

If so, there is still a warning using this issue in operators.py.

@asmeurer

asmeurer Jul 3, 2017

Member

If so, there is still a warning using this issue in operators.py.

This comment has been minimized.

@szymag

szymag Jul 4, 2017

Contributor

Since you already opened the other one with more information, should #12858 be closed?

I did not information that you mentioned me in #12858 and I didn't notice this issue. It is the reason why I opened the other one.
#12858 can be closed

@szymag

szymag Jul 4, 2017

Contributor

Since you already opened the other one with more information, should #12858 be closed?

I did not information that you mentioned me in #12858 and I didn't notice this issue. It is the reason why I opened the other one.
#12858 can be closed

This comment has been minimized.

@szymag

szymag Jul 4, 2017

Contributor

If so, there is still a warning using this issue in operators.py.

I opened proper issue #12884 and updated information in operators.py.

@szymag

szymag Jul 4, 2017

Contributor

If so, there is still a warning using this issue in operators.py.

I opened proper issue #12884 and updated information in operators.py.

@asmeurer asmeurer merged commit df019c3 into sympy:1.1 Jul 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@szymag szymag deleted the szymag:update_docs branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment