New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker functions for orthogonality of coordinate system #12882

Merged
merged 4 commits into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@szymag
Contributor

szymag commented Jul 3, 2017

This PR introduce additional condition for transformation equation which must be fulfill.
In vector module we are dealing with orthogonal curvilinear coordinate system only, so we need to check if transformation equations are correctly defined.

Closes #12852

@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 3, 2017

Contributor

ping @Upabjojr

Contributor

szymag commented Jul 3, 2017

ping @Upabjojr

@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jul 3, 2017

Contributor

Need tests.

Contributor

Upabjojr commented Jul 3, 2017

Need tests.

v2 = Matrix([diff(eq[0], self.y), diff(eq[1], self.y), diff(eq[2], self.y)])
v3 = Matrix([diff(eq[0], self.z), diff(eq[1], self.z), diff(eq[2], self.z)])
if any(simplify(i[0]+i[1]+i[2]) == 0 for i in (v1, v2, v3)):

This comment has been minimized.

@Upabjojr

Upabjojr Jul 5, 2017

Contributor

This condition is technically the condition of non-degenerancy, it is not related to the orthogonality.

@Upabjojr

Upabjojr Jul 5, 2017

Contributor

This condition is technically the condition of non-degenerancy, it is not related to the orthogonality.

This comment has been minimized.

@szymag

szymag Jul 5, 2017

Contributor

Yes, but we need to check that. Dot product with degenerated vector gives 0 and we get information that system is orthogonal but it isn't true.

@szymag

szymag Jul 5, 2017

Contributor

Yes, but we need to check that. Dot product with degenerated vector gives 0 and we get information that system is orthogonal but it isn't true.

@Upabjojr Upabjojr merged commit 8f3ceee into sympy:master Jul 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@szymag szymag deleted the szymag:check_if_orthogonal branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment