New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-12939, (allow autowrap's tempdir be a relative path) #12944

Merged
merged 1 commit into from Jul 16, 2017

Conversation

Projects
None yet
2 participants
@bjodah
Member

bjodah commented Jul 11, 2017

This works locally for me, let's see what Travis CI says.

cc @moorepants @uweschmitt

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Jul 11, 2017

Member

Why does it need to chdir at all?

At any rate, this looks good, +1.

Member

asmeurer commented Jul 11, 2017

Why does it need to chdir at all?

At any rate, this looks good, +1.

@bjodah

This comment has been minimized.

Show comment
Hide comment
@bjodah

bjodah Jul 11, 2017

Member

I don't think the chdir call is needed. I'll add a commit removing it once CI passes.

Member

bjodah commented Jul 11, 2017

I don't think the chdir call is needed. I'll add a commit removing it once CI passes.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Jul 11, 2017

Member

I guess it would need to os.path.join(self.workdir, ...) everywhere without it.

Member

asmeurer commented Jul 11, 2017

I guess it would need to os.path.join(self.workdir, ...) everywhere without it.

@bjodah

This comment has been minimized.

Show comment
Hide comment
@bjodah

bjodah Jul 11, 2017

Member

True, let's leave it there then.

Member

bjodah commented Jul 11, 2017

True, let's leave it there then.

@bjodah bjodah merged commit ece2acc into sympy:master Jul 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bjodah bjodah deleted the bjodah:fix-gh-12939 branch Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment