New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformation equations for rotation matrix #12960

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@szymag
Contributor

szymag commented Jul 13, 2017

This PR introduces transformation equations obtained from rotation matrix.

TODO:

  • Add tests for every cases. I've some doubts if rotation matrix is built correctly so I need to resolve them before finishing this PR.
@szymag

This comment has been minimized.

Show comment
Hide comment
@szymag

szymag Jul 13, 2017

Contributor

ping @Upabjojr

Contributor

szymag commented Jul 13, 2017

ping @Upabjojr

@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jul 13, 2017

Contributor

How do you deal the fact that the transformation matrix is the inverse rotation matrix?

Contributor

Upabjojr commented Jul 13, 2017

How do you deal the fact that the transformation matrix is the inverse rotation matrix?

@Upabjojr Upabjojr merged commit 2150323 into sympy:master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Upabjojr

This comment has been minimized.

Show comment
Hide comment
@Upabjojr

Upabjojr Jul 17, 2017

Contributor

@szymag I think this PR is OK. For more tests, we can just add another PR.

Contributor

Upabjojr commented Jul 17, 2017

@szymag I think this PR is OK. For more tests, we can just add another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment