New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3267: limit watches for difficult Add terms #1307

Merged
merged 1 commit into from May 27, 2012

Conversation

Projects
None yet
4 participants
@smichr
Member

smichr commented May 23, 2012

When multiple terms are unbounded/unknown, try see if the rational
form of them gives a result, and if so continue with the limit algorithm.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 23, 2012

Member

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYrfAZDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 4f9af08
branch hash: cf016cc517b45e23ec64993a8bb58ba78632854e

Automatic review by SymPy Bot.

Member

Krastanov commented May 23, 2012

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYrfAZDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 4f9af08
branch hash: cf016cc517b45e23ec64993a8bb58ba78632854e

Automatic review by SymPy Bot.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 23, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYxugZDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 4f9af08
branch hash: cf016cc517b45e23ec64993a8bb58ba78632854e

Automatic review by SymPy Bot.

Member

Krastanov commented May 23, 2012

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYxugZDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 4f9af08
branch hash: cf016cc517b45e23ec64993a8bb58ba78632854e

Automatic review by SymPy Bot.

@ness01

This comment has been minimized.

Show comment
Hide comment
@ness01

ness01 May 23, 2012

Contributor

I think this is alright, but I do not know much about the limit() function. It was my impression at the time that the right way to fix the problem would be to delegate the limit to gruntz() istead of applying a wrong heuristic. But it's been a long time ...

Contributor

ness01 commented May 23, 2012

I think this is alright, but I do not know much about the limit() function. It was my impression at the time that the right way to fix the problem would be to delegate the limit to gruntz() istead of applying a wrong heuristic. But it's been a long time ...

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 23, 2012

Member

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYlfgZDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 4f9af08
branch hash: 557b1556d307b78c941bff56971c1fc450a8f603

Automatic review by SymPy Bot.

Member

Krastanov commented May 23, 2012

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYlfgZDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 4f9af08
branch hash: 557b1556d307b78c941bff56971c1fc450a8f603

Automatic review by SymPy Bot.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 23, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY_f8ZDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 4f9af08
branch hash: 557b1556d307b78c941bff56971c1fc450a8f603

Automatic review by SymPy Bot.

Member

Krastanov commented May 23, 2012

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY_f8ZDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 4f9af08
branch hash: 557b1556d307b78c941bff56971c1fc450a8f603

Automatic review by SymPy Bot.

@smichr

This comment has been minimized.

Show comment
Hide comment
@smichr

smichr May 23, 2012

Member

I have to look at the _sift routine a bit more closely.

Member

smichr commented May 23, 2012

I have to look at the _sift routine a bit more closely.

@smichr smichr closed this May 23, 2012

@raoulb

This comment has been minimized.

Show comment
Hide comment
@raoulb

raoulb May 24, 2012

Contributor

@ness01 It seems that grutz gets 0 too.

In [9]: gruntz(r, x, 1)
Out[9]: 0

I do now know why.

Contributor

raoulb commented May 24, 2012

@ness01 It seems that grutz gets 0 too.

In [9]: gruntz(r, x, 1)
Out[9]: 0

I do now know why.

@ness01

This comment has been minimized.

Show comment
Hide comment
@ness01

ness01 May 24, 2012

Contributor

You're right. I had another limit in mind (which was also fixed in this PR). [Not sure why gruntz produces a wrong result, but I imagine symbolic parameters are going to cause trouble.]

Contributor

ness01 commented May 24, 2012

You're right. I had another limit in mind (which was also fixed in this PR). [Not sure why gruntz produces a wrong result, but I imagine symbolic parameters are going to cause trouble.]

@smichr smichr reopened this May 25, 2012

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 25, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9tUaDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 92d8dad
branch hash: b256870307a96d05c9aa47adfe1161d25cb4767b

Automatic review by SymPy Bot.

Member

Krastanov commented May 25, 2012

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9tUaDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 92d8dad
branch hash: b256870307a96d05c9aa47adfe1161d25cb4767b

Automatic review by SymPy Bot.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 25, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY390aDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 92d8dad
branch hash: b256870307a96d05c9aa47adfe1161d25cb4767b

Automatic review by SymPy Bot.

Member

Krastanov commented May 25, 2012

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY390aDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 92d8dad
branch hash: b256870307a96d05c9aa47adfe1161d25cb4767b

Automatic review by SymPy Bot.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 25, 2012

Member

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYqMYaDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 92d8dad
branch hash: 74f33cfac39d1452bd5071605a7eff05889654a3

Automatic review by SymPy Bot.

Member

Krastanov commented May 25, 2012

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYqMYaDA

Interpreter: /usr/bin/python2.6 (2.6.7-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 92d8dad
branch hash: 74f33cfac39d1452bd5071605a7eff05889654a3

Automatic review by SymPy Bot.

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 25, 2012

Member

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY2bYaDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 92d8dad
branch hash: 74f33cfac39d1452bd5071605a7eff05889654a3

Automatic review by SymPy Bot.

Member

Krastanov commented May 25, 2012

SymPy Bot Summary: 🔴 There were test failures.

@smichr: Please fix the test failures.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY2bYaDA

Interpreter: /usr/bin/python3 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes
Test command: ./bin/test && ./bin/doctest
master hash: 92d8dad
branch hash: 74f33cfac39d1452bd5071605a7eff05889654a3

Automatic review by SymPy Bot.

@smichr

This comment has been minimized.

Show comment
Hide comment
@smichr

smichr May 27, 2012

Member

OK, I'll commit this unless there are objections. As it has fixed issues without breaking others, it is at least not worse than the current situation.

Member

smichr commented May 27, 2012

OK, I'll commit this unless there are objections. As it has fixed issues without breaking others, it is at least not worse than the current situation.

3267: limit watches for difficult Add terms
In cases as noted in the code, try see if the rational
form of the terms gives a result, and if so continue with the limit algorithm.

smichr added a commit that referenced this pull request May 27, 2012

Merge pull request #1307 from smichr/3267
3267: limit watches for difficult Add terms

@smichr smichr merged commit 22ca44e into sympy:master May 27, 2012

@Krastanov

This comment has been minimized.

Show comment
Hide comment
@Krastanov

Krastanov May 27, 2012

Member

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYmPUaDA

Interpreter: /home/stefan/python2.5/Python-2.5.6/python (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 22ca44e
branch hash: 626b5c9

Automatic review by SymPy Bot.

Member

Krastanov commented May 27, 2012

SymPy Bot Summary: ✳️ All tests have passed.

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYmPUaDA

Interpreter: /home/stefan/python2.5/Python-2.5.6/python (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes
Test command: setup.py test
master hash: 22ca44e
branch hash: 626b5c9

Automatic review by SymPy Bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment