New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perm groups: a bug in minimal_block #13070

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@valglad
Contributor

valglad commented Jul 31, 2017

This PR fixes a bug in the minimal_block method for the PermutationGroup class. One of of the variables (previously temp) was unintentionally rewritten inside a for loop because the same variable name was used for a different thing. The first variable is now renamed to be gamma.

@jksuom jksuom closed this Jul 31, 2017

@jksuom jksuom reopened this Jul 31, 2017

@jksuom

This comment has been minimized.

Show comment
Hide comment
@jksuom

jksuom Aug 2, 2017

Member

Testing finally succeeded.

Member

jksuom commented Aug 2, 2017

Testing finally succeeded.

@jksuom jksuom merged commit 9eb138d into sympy:master Aug 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@valglad valglad deleted the valglad:minimal_block branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment