New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of polynomials over 3-Polytopes #13082

Merged
merged 7 commits into from Aug 23, 2017

Conversation

Projects
None yet
2 participants
@ArifAhmed1995
Contributor

ArifAhmed1995 commented Aug 2, 2017

The functions should be the same for 3D and 2D case.

@ArifAhmed1995 ArifAhmed1995 changed the title from [WIP]Basic 3D prototype with constant expression to [WIP]Basic 3D prototype for Integration over Polytopes Aug 3, 2017

@ArifAhmed1995

This comment has been minimized.

Show comment
Hide comment
@ArifAhmed1995

ArifAhmed1995 Aug 13, 2017

Contributor

@certik Review please.

Contributor

ArifAhmed1995 commented Aug 13, 2017

@certik Review please.

@certik

certik approved these changes Aug 15, 2017

I think this looks very good.

Let's add more tests. @ndotsu suggested to use some of the more complicated 3D polyhedra from Mathematica (http://reference.wolfram.com/language/ref/PolyhedronData.html).

Let's try to reproduce some of the results from @ndotsu's poster and/or paper.

Show outdated Hide outdated sympy/integrals/intpoly.py

@ArifAhmed1995 ArifAhmed1995 changed the title from [WIP]Basic 3D prototype for Integration over Polytopes to Integration of polynomials over 3-Polytopes Aug 22, 2017

@certik

certik approved these changes Aug 23, 2017

Good job @ArifAhmed1995, I think this looks great. Merging.

@certik certik merged commit 7f94d5e into sympy:master Aug 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ArifAhmed1995 ArifAhmed1995 deleted the ArifAhmed1995:intpoly3d branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment