New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .codegen.rewriting module #13194

Merged
merged 3 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@bjodah
Member

bjodah commented Aug 25, 2017

This module is useful for rewriting symbolic expressions to target specific floating point functions in e.g. C99.

@bjodah bjodah referenced this pull request Aug 26, 2017

Merged

Add .codegen.approximations #13200

1 of 1 task complete

@smichr smichr changed the title from Add .codgen.rewriting module to Add .codegen.rewriting module Aug 26, 2017

Address review (doc & compatibility)
- Added filterfalse to sympy.core.compatiblity
- Fixed formatting of docstrings in .codegen.rewriting
- Ensured doctests are run on module level docstring of .codegen.rewriting
@bjodah

This comment has been minimized.

Show comment
Hide comment
@bjodah

bjodah Aug 27, 2017

Member

Thanks @smichr
I've always been a bit confused regarding ==== vs. ----- (numpydoc guidelines are in favor of the latter but you're right that SymPy usually uses the former).

I haven added the module to doc/src/modules/codegen.rst since that would just give a merge conflict with #13100, but once one of these are merged I'll merge master in and add it.

Member

bjodah commented Aug 27, 2017

Thanks @smichr
I've always been a bit confused regarding ==== vs. ----- (numpydoc guidelines are in favor of the latter but you're right that SymPy usually uses the former).

I haven added the module to doc/src/modules/codegen.rst since that would just give a merge conflict with #13100, but once one of these are merged I'll merge master in and add it.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Aug 28, 2017

Member

This looks like a good start.

Member

asmeurer commented Aug 28, 2017

This looks like a good start.

@bjodah bjodah merged commit 83bcbc0 into sympy:master Aug 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bjodah bjodah deleted the bjodah:codegen-rewrite branch Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment