converted except BaseException to except NotImplementedError #13342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partial fix to #11668 |
|
Can anyone please review this pull request? |
|
@nilabja10201992 thanks for the pull request, its in :) . Thanks @smichr for the review. |
|
@gxyd Thank you for guiding me, I'm grateful that my request was merged. I want to contribute more, please suggest me some easy fixes that will be good to start with. |
|
It's good that you got back (even after quite a few months) to complete the PR. One issue that I can guide you on is #13111 . Its an easy to fix issue. I'll be active in the morning IST time(between 9 AM to 11 AM). |
|
@gxyd Yes, there is lots of code that is of type (expr.func is xyz) in core folder of sympy, should I fix all of them? I'll be active in github tomorrow by 9:30 AM IST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in pull request #12072 I've converted expect BaseException to except NotImplementedError