Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuum_mechanics : added more beam problems #14453

Merged
merged 5 commits into from Aug 2, 2018

Conversation

Projects
None yet
6 participants
@jashan498
Copy link
Contributor

jashan498 commented Mar 9, 2018

Added exemplar problems :

                                    20KN         8KN
       10 KN/m                      ||           ||
     ||||||||||||||                 \/           \/
      _______________________________________________
     |_______________________________________________|         
           /\                                 OOO

     |-----|------|-----------------|----------|--|--|
        1m    1m          3m              2m   .5m .5m
                           ramp laod
                       |---------------|
                          12 KN
  \\\\|  4 KN/m            ||
  \\\\||||||||||||         \/
  \\\\|________________________________
  \\\\|________________________________|                              
  \\\\|          :          :          :
  \\\\|----------|-----|----|----------|  

          2.0 m     1m   1m      2.0 m
                   2 KN/m
              |||||||||||||||||
      ____________________________________________________ 
     O____________________________________________________| o 5KN-m        
    / \                                   /\                

     |--------|----------------|----------|---------------|
         2m           4m            2m            3m

Release Notes

  • physics.continuum_mechanics
    • added more Beam examples.
and supported by a roller 1 meter before the other end. It is subjected
to a distributed constant load of 10 KN/m from the starting point till
2 meters away from it. Two pointloads of 20KN and 8KN are applied at
5 meters and 7.5 meters away from the starting point respectively.

This comment has been minimized.

@moorepants

moorepants Mar 10, 2018

Member

Did you come up with this wording or is it copied from a book, etc?

This comment has been minimized.

@jashan498

jashan498 Mar 10, 2018

Author Contributor

These were specific questions like "Find max deflection in the beam " along with a diagram given. So yeah, I wrote the wording on my own.

This comment has been minimized.

@moorepants

moorepants Jul 28, 2018

Member

Ok, that's good then, we just want to abide by copyright rules.

Using the sign convention of upward forces and clockwise moment
being positive.

>>> from sympy.physics.continuum_mechanics.beam import Beam

This comment has been minimized.

@moorepants

moorepants Mar 10, 2018

Member

These should be in in .. code:: blocks I believe.

@Abdullahjavednesar

This comment has been minimized.

Copy link
Member

Abdullahjavednesar commented Apr 14, 2018

@moorepants
Copy link
Member

moorepants left a comment

This looks fine. Please add in your ASCII art beams into the rst files if possible. That really helps the reader understand the problem.

@@ -56,45 +56,46 @@ of 12 kN is applied at the end.
Since a user is free to choose its own sign convention we are considering
the upward forces and clockwise bending moment being positive.

.. code::

This comment has been minimized.

@moorepants

moorepants Jul 28, 2018

Member

I think you can use .. code:: pycon for correct syntax highlighting if it doesn't do it correctly by default.

@parsoyaarihant

This comment has been minimized.

Copy link
Contributor

parsoyaarihant commented Aug 1, 2018

@jashan498 ping.

@sympy-bot

This comment has been minimized.

Copy link

sympy-bot commented Aug 1, 2018

Hi, I am the SymPy bot (v123). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

Added exemplar problems : 
```
                                    20KN         8KN
       10 KN/m                      ||           ||
     ||||||||||||||                 \/           \/
      _______________________________________________
     |_______________________________________________|         
           /\                                 OOO

     |-----|------|-----------------|----------|--|--|
        1m    1m          3m              2m   .5m .5m
```
```
                           ramp laod
                       |---------------|
                          12 KN
  \\\\|  4 KN/m            ||
  \\\\||||||||||||         \/
  \\\\|________________________________
  \\\\|________________________________|                              
  \\\\|          :          :          :
  \\\\|----------|-----|----|----------|  

          2.0 m     1m   1m      2.0 m
```
```
                   2 KN/m
              |||||||||||||||||
      ____________________________________________________ 
     O____________________________________________________| o 5KN-m        
    / \                                   /\                

     |--------|----------------|----------|---------------|
         2m           4m            2m            3m
```

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. If there is no release notes entry for this PR,
write "NO ENTRY". The bot will check your release notes automatically to see
if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.continuum_mechanics
  * added more Beam examples.
<!-- END RELEASE NOTES -->

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Update

The release notes on the wiki have been updated.

@jashan498 jashan498 force-pushed the jashan498:beam_examples branch from 82e29a3 to 0114995 Aug 1, 2018

\/______________________________________________|
|_______________________________________________|
/\ /\
|------------|---------------------------------|

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

Do these render correctly when you build the docs?

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

I get this error:


Warning, treated as error:
/home/moorepants/src/sympy/doc/src/modules/physics/continuum_mechanics/beam_problems.rst:56:Block quote ends without a blank line; unexpected unindent.
Makefile:49: recipe for target 'html' failed
make: *** [html] Error 2

Make sure to build the docs locally.

is applied from the mid till the end of the beam.

ramp laod = 1 KN/m
constant laod = 3 KN/m

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

laod > load

@jashan498 jashan498 force-pushed the jashan498:beam_examples branch from 7c34886 to ee1fde7 Aug 1, 2018

@jashan498 jashan498 force-pushed the jashan498:beam_examples branch from ee1fde7 to 607ef91 Aug 1, 2018


12 KN
\\\\| 8 KN/m ||
\\\\|||||||||||| 50 KN-m \/

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

Shouldn't the vertical lines go to the 5 meter mark?

This might look better for distrubted force:

    8 KN/m
_____________
| | | | | | |
V V V V V V V
\\\\| 8 KN/m ||
\\\\|||||||||||| 50 KN-m \/
\\\\|________________|_______________
\\\\|________________|_______________|

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

Maybe use @ or o to show the location of the moment.

There are also unicode arrows you can use, like: ⭯

This comment has been minimized.


ramp load = 1 KN/m
constant load = 3 KN/m
|-----------------------|

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

shift one left

|||||||||||||| \/ \/
_______________________________________________
|_______________________________________________|
/\ OOO

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

Maybe roller:

 /\
oooo

or just a single o.

|---------------|
12 KN
\\\\| 4 KN/m ||
\\\\|||||||||||| \/

This comment has been minimized.

@moorepants

moorepants Aug 1, 2018

Member

I think you can overlap the ramp load at the point load. Also you can probably make it look like a ramp.

@moorepants

This comment has been minimized.

Copy link
Member

moorepants commented Aug 1, 2018

Please address my latest comments and I think we can merge then. Thanks.

@jashan498

This comment has been minimized.

Copy link
Contributor Author

jashan498 commented Aug 2, 2018

@moorepants some jobs are failing unexpectedly and need to be restarted.

@jksuom

This comment has been minimized.

Copy link
Member

jksuom commented Aug 2, 2018

There were two that hadn't even started and one with connection failure. That is unusual.

@moorepants moorepants merged commit 6810dee into sympy:master Aug 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.