Skip to content

Incremental Schreier-Sims algorithm, and subgroup searching. #1454

Merged
merged 13 commits into from Aug 7, 2012

5 participants

@amakelov

Implemented a version of the Schreier-Sims algorithm that takes a sequence of points and a generating set for a group and extends them to a base and strong generating set.

Implemented a procedure to remove redundant generators from a strong generating set.

Implemented the procedure subgroup_search which finds generators for the subgroup of all elements satisfying a given property in a larger group.

@travisbot

This pull request passes (merged a6253a17 into 02daa7d).

@Krastanov
SymPy member

SymPy Bot Summary: 🔴 There were test failures.

@amakelov: Please fix the test failures.

Test command: setup.py test
master hash: 02daa7d
branch hash: a6253a17db5652b928f21db5b05a45d837016786

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYnbYiDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY3PQiDA

Interpreter 3: ✳️ All tests have passed.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYmI8iDA

Build HTML Docs: 🔴 There were test failures.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYn90iDA

Automatic review by SymPy Bot.

@travisbot

This pull request passes (merged 02198cca into 02daa7d).

@Krastanov
SymPy member

SymPy Bot Summary: 🔴 There were test failures.

@amakelov: Please fix the test failures.

Test command: setup.py test
master hash: bff3595
branch hash: 02198ccac5a5838a94afb875d5f23470da9a9fce

Interpreter 1: 🔴 There were test failures.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY8MUiDA

Interpreter 2: 🔴 There were test failures.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYiIwjDA

Interpreter 3: ✳️ All tests have passed.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY4fQiDA

Build HTML Docs: 🔴 There were test failures.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY1M0iDA

Automatic review by SymPy Bot.

Aleksandar M... added some commits Jul 29, 2012
Aleksandar Makelov Incremental Schreier-Sims algorithm.
It is used to extend a sequence of points and a generating set
to a base and strong generating set relative to it.
c592584
Aleksandar Makelov Tests for incremental Schreier-Sims algorithm. 2090a19
Aleksandar Makelov Remove redundant strong generators from a strong generating set.
Via the function _remove_gens in sympy/combinatorics/util.py
b852d89
Aleksandar Makelov Subgroup search and tests for _remove_gens.
The function subgroup_search is used to find a strong generating
set for the subgroup of all elements satisfying a given property
within a group.
454268c
Aleksandar Makelov Added tests for subgroup search. be08509
Aleksandar Makelov Removed the use of baseswap from subgroup search; minor changes.
Due to a bug in the version of subgroup_search using baseswap
to perform the base changes, the way basic stabilizers are
obtained is now via the stabilizer() function. The function
_insert_point_in_base was remove from sympy.combinatorics.util
since it's not needed right now.

Also, made the incremental Schreier-Sims algorithm exclude the
identity element as a generator and wrote some more tests
for subgroup_search
0cdee22
Aleksandar Makelov Removed unnecessary code from subgroup_search. 1ad8444
Aleksandar Makelov Added docstrings for the new functions. fabddb8
Aleksandar Makelov Minor style improvements. 8820277
Aleksandar Makelov Got rid of lines longer than 80 characters. ea648ae
Aleksandar Makelov Renamed all variables `distr_gens` to `strong_gens_distr`.
For more clarity, as suggested by my GSoC mentor David. This
variable is usually used to denote a list of strong generators
distributed by membership in basic stabilizers.
03f2c95
Aleksandar Makelov Fixed some issues with the docs. b4cc733
Aleksandar Makelov Removed side effects from schreier_sims_incremental. 4dffbde
@travisbot

This pull request passes (merged 4dffbde into 65b6582).

@Krastanov
SymPy member

SymPy Bot Summary: ✳️ All tests have passed.

Test command: setup.py test
master hash: 3c2c3c7
branch hash: 4dffbde

Interpreter 1: ✳️ All tests have passed.

Interpreter: /usr/local/bin/python2.5 (2.5.6-final-0)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYhsYiDA

Interpreter 2: ✳️ All tests have passed.

Interpreter: /usr/bin/python2.7 (2.7.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY9JsjDA

Interpreter 3: ✳️ All tests have passed.

Interpreter: /usr/bin/python3.2 (3.2.3-candidate-2)
Architecture: Linux (64-bit)
Cache: yes

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sY8f8hDA

Build HTML Docs: ✳️ All tests have passed.

Docs build command: make html-errors
Sphinx version: 1.1.3

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYp4wjDA

Automatic review by SymPy Bot.

@wdjoyner
wdjoyner commented Aug 7, 2012

This patch looks good to me and it passes all tests.

@asmeurer
SymPy member
asmeurer commented Aug 7, 2012

OK, I'll merge it then.

@asmeurer asmeurer merged commit c7a4a4a into sympy:master Aug 7, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.