Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
integer_nthroot: Fixing OverflowError in integer_nthroot() #14707
integer_nthroot: Fixing OverflowError in integer_nthroot()
In function integer_nthroot(), line 76 breaks, raising the OverflowError when 'n' (the denominator) becomes a very large integer -- for eg., math.factorial(171). Therefore, this PR rounding the numerator to the integer value.
referenced this pull request
May 17, 2018
This is probably partly caused by the computation of
In this loop,
With a patch of this type it should be possible to add a test for
Can we speed up inequality tests (after the guess has been made) by floating point comparison of their log values (assuming they won't be too big)?