New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not to be Merged] Rubi progress #14724

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ashishkg0022
Contributor

ashishkg0022 commented May 17, 2018

Currently I have properly implemented a structure with the following :

  1. Fixed issue of parsetools
  2. No lambdas anywhere
  3. Generate a single constraint file
  4. Fixed order in which rules are matched. It was the greatest cause of recursion errors. I have kept a uniform numbering of rules.
  5. Generated through parsetools.

asmeurer and others added some commits May 1, 2018

Make lambdify decorator a little faster
I pulled out the common functionality to be evaluated once, and used array()
instead of asarray() (they are equivalent, but array() is faster).

This is a partial fix to #14671. It isn't as fast as it used to be yet. I
don't know how to make the decorator faster, other than code generating the
array wrapping directly, which would require improvements to lambdify to work
(lambdify would need to be able to code generation full Python functions).
@ashishkg0022

This comment has been minimized.

Contributor

ashishkg0022 commented May 17, 2018

@@ -106,6 +107,7 @@ def test_Coefficient():
assert Coefficient(a + b*x + c*x**3, x, 0) == a
assert Coefficient(a + b*x + c*x**3, x, 4) == 0
assert Coefficient(b*x + c*x**3, x, 3) == c
assert Coefficient(x, x, -1) == 0

This comment has been minimized.

@Abdullahjavednesar

Abdullahjavednesar May 20, 2018

Contributor

Wasn't this passing before?

This comment has been minimized.

@ashishkg0022

ashishkg0022 May 21, 2018

Contributor

No , It was causing an exception.

This comment has been minimized.

@Abdullahjavednesar

Abdullahjavednesar May 21, 2018

Contributor

Well the use of expand looks good.

@ashishkg0022 ashishkg0022 deleted the ashishkg0022:rubi_progress branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment