Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subset convolution for discrete module #14878

Merged
merged 2 commits into from Jul 8, 2018

Conversation

Projects
None yet
2 participants
@sidhantnagpal
Copy link
Member

sidhantnagpal commented Jul 7, 2018

The method convolution_subset and corresponding keyword subset for exportable method convolution is added, which expects sequences for which the convolution is performed.

The indices of arguments considered as bitmasks correspond to subsets of a finite set.

>>> convolution_subset([u, v], [x, y])
 [u*x, u*y + v*x]

>>> convolution([u, v, x], [y, z], subset=True)
[u*y, u*z + v*y, x*y, x*z]

>>> convolution([u, v, x], [y, z], subset=True, cycle=3)
[u*y + x*z, u*z + v*y, x*y]

sidhantnagpal added some commits Jul 6, 2018

@jksuom

This comment has been minimized.

Copy link
Member

jksuom commented Jul 8, 2018

I think this is ready to be merged.

@jksuom jksuom merged commit f384c73 into sympy:master Jul 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.