Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup discrete.convolution and combinatorial.factorials #14907

Merged
merged 5 commits into from Jul 15, 2018

Conversation

Projects
None yet
3 participants
@sidhantnagpal
Copy link
Member

sidhantnagpal commented Jul 13, 2018

References to other Issues or PRs

Address review in #14745
Fixes #14901

sidhantnagpal added some commits Jul 13, 2018

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 13, 2018

Replace **hints in the function definition with explicit keyword arguments (cycle=0, dps=None, ...)

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 13, 2018

See also #14030

sidhantnagpal added some commits Jul 14, 2018

@jksuom jksuom merged commit e53b24a into sympy:master Jul 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.