Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unset_show now works with TextBackend too #14984

Merged
merged 3 commits into from Jul 28, 2018

Conversation

Projects
None yet
4 participants
@jashan498
Copy link
Contributor

jashan498 commented Jul 27, 2018

Brief description of what is fixed or changed

Also added unset_show in utilities/runtests to stop showing up of plots in doctest.

Based on conversation happened on Gitter.

Release Notes

NO ENTRY

unset_show now works with TextBackend too
Added unset_show in runtests to stop showing up of plots in doctest
@sympy-bot

This comment has been minimized.

Copy link

sympy-bot commented Jul 27, 2018

Hi, I am the SymPy bot (v119). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

#### Brief description of what is fixed or changed
Also added `unset_show` in `utilities/runtests` to stop showing up of plots in doctest.

Based on conversation happened on Gitter.
#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. If there is no release notes entry for this PR,
write "NO ENTRY". The bot will check your release notes automatically to see
if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 27, 2018

I'm curious why this didn't already show up in the Travis tests? Are the plotting doctests skipped if matplotlib isn't installed?

@jashan498

This comment has been minimized.

Copy link
Contributor Author

jashan498 commented Jul 27, 2018

yeah they are skipped due to doctest_depends_on decorator used for those methods.

@asmeurer

This comment has been minimized.

Copy link
Member

asmeurer commented Jul 27, 2018

So should remove those decorators since the plotting still does work with textplot?

@jksuom

This comment has been minimized.

Copy link
Member

jksuom commented Jul 28, 2018

This looks good to me. There should be no reason to treat the two plotting backends differently in general. There is an unset_show() concerning matplotlib alone in runtests. That could probably be removed now.

@jksuom

This comment has been minimized.

Copy link
Member

jksuom commented Jul 28, 2018

Thanks, merging.

@jksuom jksuom merged commit 274ab59 into sympy:master Jul 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
sympy-bot/release-notes The release notes look OK
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.